From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C171D42F19 for ; Sun, 11 Sep 2022 04:30:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9AA1C68BAB9; Sun, 11 Sep 2022 07:30:02 +0300 (EEST) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C1EB468BA0A for ; Sun, 11 Sep 2022 07:29:54 +0300 (EEST) Received: from 15fc8db07f19f8c510f57cfd648a18df ([1.136.235.79]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 28B4Thgc020263 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 11 Sep 2022 04:29:47 GMT Date: Sun, 11 Sep 2022 14:29:37 +1000 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: multipart/mixed; boundary="===============2034566933282145484==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2034566933282145484== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6aKKvkSyokbgWU3R" Content-Disposition: inline --6aKKvkSyokbgWU3R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: > It is a VP8-only feature. >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp8.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c > index c00c5c975e..04a2113cc8 100644 > --- a/libavcodec/vp8.c > +++ b/libavcodec/vp8.c > @@ -637,7 +637,6 @@ static int vp7_decode_frame_header(VP8Context *s, con= st uint8_t *buf, int buf_si > for (i =3D 0; i < 2; i++) > memcpy(s->prob->mvc[i], vp7_mv_default_prob[i], > sizeof(vp7_mv_default_prob[i])); > - memset(&s->lf_delta, 0, sizeof(s->lf_delta)); > memcpy(s->prob[0].scan, ff_zigzag_scan, sizeof(s->prob[0].scan)); > } > =20 > @@ -2171,7 +2170,7 @@ void filter_level_for_mb(VP8Context *s, VP8Macroblo= ck *mb, > } else > filter_level =3D s->filter.level; > =20 > - if (s->lf_delta.enabled) { > + if (!is_vp7 && s->lf_delta.enabled) { > filter_level +=3D s->lf_delta.ref[mb->ref_frame]; > filter_level +=3D s->lf_delta.mode[mb->mode]; > } what's the motivation for patches 01 and 02? are you not just adding another condition (is_vp7) to evaluate at decode ti= me? if its improved readability, then suggest renaming 'lf_delta' to 'lf_delta_= vp8' pathces 3-18 look fine to me. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --6aKKvkSyokbgWU3R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iFwEABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCYx1kLQAKCRBnYHnFrEDd a1HFAJUetnsfQvhZIBlfZplKSGY9RDVHAKCyQLqs1MwaRNKnmQcmcQgm2oiWKA== =1/6a -----END PGP SIGNATURE----- --6aKKvkSyokbgWU3R-- --===============2034566933282145484== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2034566933282145484==--