From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3D80743EDF for ; Wed, 17 Aug 2022 08:59:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9D9E768B72B; Wed, 17 Aug 2022 11:59:10 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8370668B321 for ; Wed, 17 Aug 2022 11:59:03 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 27H8x2Zw018751 for ; Wed, 17 Aug 2022 10:59:02 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id ABF20E0101; Wed, 17 Aug 2022 10:59:02 +0200 (CEST) Date: Wed, 17 Aug 2022 10:59:02 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <3476fe9f-0433-99fa-0f0f-451f4062a7c8@mail.de> <166065902371.3205.13528205845420475535@lain.khirnov.net> <166072430421.4001.1353603178221790793@lain.khirnov.net> <35f0db7c-0ad8-506b-c09a-7948f79c71eb@gyani.pro> MIME-Version: 1.0 In-Reply-To: <35f0db7c-0ad8-506b-c09a-7948f79c71eb@gyani.pro> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 17 Aug 2022 10:59:02 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4423888994071127179==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4423888994071127179== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wrL/8EkSQcxw+3ri" Content-Disposition: inline --wrL/8EkSQcxw+3ri Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Gyan Doshi (12022-08-17): > It's not based on ffmpeg's 'internal representation'. All transform > attributes are stored as a composite in one mathematical object. > Evaluating the matrix values will need to look at all sources of > contribution. So gathering and presenting all these attributes in a single > option (+ docs) makes it clearer to the user at the cost of an initial > learning curve. I concur a single option might be more convenient. Especially since our options system does not take into account the order of options: the interactions between multiple options would be rather hard to explain. OTOH, I do not like a dictionary-based approach, for the same reason: you have to explain the order of precedence of options, and how contradicting ones interact. Might I suggest to adopt the syntax of the transform attribute of SVG? Or a subset of it with a stricter syntax. https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/transform It requires writing a specific parser, but one that can be done with sscanf(): if (sscanf(cur, "translate(%d %d)%n", &dx, &dy, &off) >=3D 2 && off) { translate_current_matrix(&mat, dx, dy); cur +=3D off; } Regards, --=20 Nicolas George --=20 =E2=80=9CI dont see why=E2=80=9D isnt an argument. Proposing better is. --wrL/8EkSQcxw+3ri Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmL8rdQACgkQcZVLI8pN xgw4xg/+Jsu3EuMbeIq98b8y1y96GVuM2jABrOVgi5yoyxB0IochIuxK9H5rH9FU eMzwXz5tRIRVmLbc9XlxseyqWftFx1W+yHMpYn6dx7COMHrQoMFOGqGpK6P4QtxU la13S/UBsKEXvdNZQevTUEVA3C28jsvR5CpfZDukbvYXm/cHJzBdsSvyTOKEgKvr cyoHHJ6Jcah4GxdD1R+AzPSQ5C4qCXTtVnzCDvtZ0gxSstgAU3jEU8miEW12DoQ4 nPz40lKnySFPIIfGXl/gtwIRFKi7qmR2x0vl90d2wZZa+Y2ZgBak8YgDXbYQEDto Ic14mZhEref4qziWMAAaJJqCq9m23Gulm1XvW4ssfcmM9pBq3KrxHygRTI9v2ybl dmlR3nlKZ1hBpYQS+XsewH4J4t0iE05WKDDMBlqRjraYCTyR6Yqy5XVi+ScBWTFq Chy9H3s+h8OB6j9oZzUqJz7HvzX9ywSvocEp9pE8klxihnEzaM0j1trtJhm3vFMp 0SEbt02WbkMvVyX1DGY4INW6tkGCzbgoBqtslbE6Fn7o/cDsROkgF7fD/D8uBras W/yU4ntigFwERnTEcMFBNbQ91OlkHQR/7a07gX0MRpioVdPwT7dWn73JsF2vskH0 t02NGBoEOt5+3Pa2Kon5yOaGzctBK22Logy3t5XA2ksDtjDWVB8= =NOvd -----END PGP SIGNATURE----- --wrL/8EkSQcxw+3ri-- --===============4423888994071127179== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4423888994071127179==--