From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DA60443C6A for ; Wed, 27 Jul 2022 18:40:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 31E7768B914; Wed, 27 Jul 2022 21:40:47 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E246268B87D for ; Wed, 27 Jul 2022 21:40:40 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 26RIeewG014725 for ; Wed, 27 Jul 2022 20:40:40 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id E4AD4EB5B9; Wed, 27 Jul 2022 20:40:39 +0200 (CEST) Date: Wed, 27 Jul 2022 20:40:39 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 27 Jul 2022 20:40:40 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort(). X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7151807232546806508==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7151807232546806508== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7vfHjTUWZf4V7U5f" Content-Disposition: inline --7vfHjTUWZf4V7U5f Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Julien Vary (12022-07-27): > >Or maybe we could add av_abort() as an alias to av_assert0(0), which > >eventually just calls abort()... >=20 > I agree that if the goal is to bail-out on 'should-not-be-reachable' > code, something that alias av_assert0(0) seems a great idea. > Shall we then give a more descriptive name than plain "av_abort()" for th= ose situations? >=20 > Nicolas George & Hendrik Leppkes ? Your thoughts ? I like =E2=80=9Cav_assert0(!"reason");=E2=80=9D better than a blanket 0. It can be a good habit to take from now on, but I do not think it is worth changing the whole code. av_assert0() calls av_log(), which can call user callbacks or allocate memory: for dangerous cases, a real immediate abort() is still better. Regards, --=20 Nicolas George --7vfHjTUWZf4V7U5f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmLhhqUACgkQcZVLI8pN xgyr9g/+K/Y2OzD4+7YNy/Mp1MfSbQkVvGukgSh8ygd1vM/u2XbSbULbyeBTVOLg afd9aKH/8o+YXwGDB9+azhGNMDD23d1Ew17Li7eLE0w5vH6UoFzUD+24PvAYCYtC rFhGxauO1s7XZrOQDkKbrHmzSAfZkaquvdrqQHEJxR7TZtDP6mJyWTNf0gluuPTb /ehrbP0UM/mUFilcGkJLERq0UH7S1PE8U7vSeDOFLx4jCuf60OA1klSk+0iBzYpK 8SN7hhYkLWgmGGiY3IYp9R8BiOdlbEz+NqeqkaxsG6dNu2jHouv5WCE6D0Itekzd AquE/IWRU2GUWr0Qa+3tjADQNXc7v0lU7IekW7w1BTZh36vtLqYD31drR6Pt6bhz 9MYfWFCd2DvgN8hFEwc2YZ47ZQ2roJEbYu3y7lPbIH+odLFxQyV1WhmX1gsS8+pr e+MImzicQBrwn9rQaJ5MXPLxcdE5Yyfxf3QKOdvsUWKuEOFUbjfqAKDgC7ACOq1R G4oFUk+UH5HUm3jrV90Z8DXnV/KSneCHGseII2MjZG3uDq6quRwgUIz6C8y8vGl9 FFIaQo7nAxmimga2uxqgaN3meKGrDUU7ebaqTfzXKgX13+eY9lFbdjt5hzA0T20D tq5Y6vP9V6P80S+lRFmdjdyNIn5pHB61i8XAL+3ylg1eFRc8jyI= =10/Y -----END PGP SIGNATURE----- --7vfHjTUWZf4V7U5f-- --===============7151807232546806508== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7151807232546806508==--