Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().
Date: Wed, 27 Jul 2022 20:40:39 +0200
Message-ID: <YuGGp5z2S1QUzAzp@phare.normalesup.org> (raw)
In-Reply-To: <DM4PR18MB41280E8C835C7680E1F4CF1EB8979@DM4PR18MB4128.namprd18.prod.outlook.com>

[-- Attachment #1.1: Type: text/plain, Size: 779 bytes --]

Julien Vary (12022-07-27):
> >Or maybe we could add av_abort() as an alias to av_assert0(0), which
> >eventually just calls abort()...
> 
> I agree that if the goal is to bail-out on 'should-not-be-reachable'
> code, something that alias av_assert0(0) seems a great idea.
> Shall we then give a more descriptive name than plain "av_abort()" for those situations?
> 
> Nicolas George & Hendrik Leppkes ? Your thoughts ?

I like “av_assert0(!"reason");” better than a blanket 0.

It can be a good habit to take from now on, but I do not think it is
worth changing the whole code.

av_assert0() calls av_log(), which can call user callbacks or allocate
memory: for dangerous cases, a real immediate abort() is still better.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".