From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E74343744 for ; Wed, 27 Jul 2022 15:28:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 45BFF68B7C9; Wed, 27 Jul 2022 18:28:51 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9A94668B72C for ; Wed, 27 Jul 2022 18:28:44 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 26RFShmv010515 for ; Wed, 27 Jul 2022 17:28:44 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id E3635EB5B9; Wed, 27 Jul 2022 17:28:43 +0200 (CEST) Date: Wed, 27 Jul 2022 17:28:43 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 27 Jul 2022 17:28:44 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort(). X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8434718959892902902==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8434718959892902902== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ov1/ohD5b3rpNQkE" Content-Disposition: inline --ov1/ohD5b3rpNQkE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Julien Vary (12022-07-27): > Replaced all abort() by av_abort() in the code. > On production systems, when dealing with malformed data, > avcodec was sometime aborting, with no core/memory dump > available to troubleshoot after-the-fact. > Adding av_abort_set_callback to register a custom > function (instead of the default straight abort() > behavior), to allow dumping before the actual abort(). > Also 'av_logging' the av_abort() location. I think it is a very bad idea. The point of abort() is that it is immediate, so that backtraces are clean and bugs cannot be compounded by further processing. A program that terminates on abort() does leave a core dump, I just checked. --=20 Nicolas George --ov1/ohD5b3rpNQkE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmLhWakACgkQcZVLI8pN xgzH6A/8CKuLnQ4JQAqAMD5KO57/FcIYUD1UHAO1VrIHdljJ3glgYpxYWrG+Uzjm myhQt9HvYyygjs81O9ZdMiDrjYQ0Gckf4fGWVLcZvqQC+CfXND9i6yUwqh7FHrp1 GapLFLO/ib/9Sqy/p7egf/ypfFmsglx3tpdiVE/L/wt4it76Yh69iSCpBSLTSCTf zGMswr1lqhsmUscGzAaKwp9QtRH/k3nCI5Xavn4aLaT6W9jvKrbBdRxPPQxj1s5T HyELEAAzi0rOQk3hBVY/FWQGvx4sZaCgCvyvpTkuIzUlslpegw8SKDs/3O+lk7mQ F7t3Yj4wQ+Vnxl3iHVcjPBSNOV7QgeiDMv67jX3Lm4oEDpxm2V42JkF0WCFG/upW CzrhPnUxhuXNpcQUNPx/LMP460IttKAxvUAMZU0uOAXRN2MD+9et2/Yp6ciI5oaY LkByLS+bG2Ko6vmsjCwqnc1kX3dFUP9ICpao86X3kFrilbzThF4//oYf9tyOTe31 iwqqGPXJhJYyRtid7PdpiGVVTdv4VdHAqPOHfego3/J/zrjciTS2Dw/QMkO69+sw QF3xeQ3By1AgTO7HEuFuXtD43FGnm9XuatYPesgAynAvigUg+Urzh3wTBhvF4hMT tixGr/iULD8cSsfDNojAePMIiWuo8AkhX7HgJmeJ2uQxDmCx8Cs= =NENQ -----END PGP SIGNATURE----- --ov1/ohD5b3rpNQkE-- --===============8434718959892902902== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8434718959892902902==--