From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().
Date: Wed, 27 Jul 2022 17:28:43 +0200
Message-ID: <YuFZq+dyeUSGDayM@phare.normalesup.org> (raw)
In-Reply-To: <DM4PR18MB4128E0CD67C12B8A85727C40B8979@DM4PR18MB4128.namprd18.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 723 bytes --]
Julien Vary (12022-07-27):
> Replaced all abort() by av_abort() in the code.
> On production systems, when dealing with malformed data,
> avcodec was sometime aborting, with no core/memory dump
> available to troubleshoot after-the-fact.
> Adding av_abort_set_callback to register a custom
> function (instead of the default straight abort()
> behavior), to allow dumping before the actual abort().
> Also 'av_logging' the av_abort() location.
I think it is a very bad idea. The point of abort() is that it is
immediate, so that backtraces are clean and bugs cannot be compounded by
further processing.
A program that terminates on abort() does leave a core dump, I just
checked.
--
Nicolas George
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-27 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 14:02 Julien Vary
2022-07-27 15:28 ` Nicolas George [this message]
2022-07-27 16:01 ` Hendrik Leppkes
2022-07-27 16:52 ` Julien Vary
2022-07-27 16:57 ` Andreas Rheinhardt
2022-07-27 17:39 ` Marton Balint
2022-07-27 18:13 ` Julien Vary
2022-07-27 18:40 ` Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuFZq+dyeUSGDayM@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git