Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] ABI break in 5.1
Date: Sat, 23 Jul 2022 16:32:25 +0200
Message-ID: <YtwGeaYM7b3UUHoc@phare.normalesup.org> (raw)
In-Reply-To: <o5roo936-3124-4169-12q2-n881n2138np@vanv.qr>


[-- Attachment #1.1: Type: text/plain, Size: 2140 bytes --]

Jan Engelhardt (12022-07-23):
> As I have previously explained,
> [ http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265705.html ]

Read the replies that have been made to you at the time.

> (Or, in today's terms, a program built with 5.1 but which is
> combined with 5.0 at runtime, then this can happen:
> 
> $ ./a.out 
> ./a.out: symbol lookup error: ./a.out: undefined symbol: avio_vprintf, 
> version LIBAVFORMAT_59

This is a perfectly normal outcome.

> >"""Running against an older version then the build version is never
> >supported
> >
> >A distribution should never allow this to happen."""
> 
> This is exactly what we're trying to do. ELF symbol version definitions 
> are *the* tool to do this, but we keep getting screwed over by terrible 
> symbol version management in ffmpeg.

No, the ELF symbol version system cannot prevent you from replacing a
file with an older version. The tool to prevent that is the package
manager of the distribution, and it obviously depends on the
distribution. With Debian, it looks like that:

Depends: libavcodec59 (>= 7:5.0)

What symbol versioning can achieve at most is turn a dangerous late
incompatibility, such as accessing a field that was added in the new
version, into an immediate harmless crash like the one you quoted above.

> libavformat.v advertises a verdef (that one being "LIBAVUTIL_59" 
> currently), but you keep modifying the set of symbols, such as dropping 
> avio_vprintf.

Please point the commit where we dropped avio_vprintf. It would be a
severe mistake. But to the better of my knowledge we avio_vprintf was
added about a month ago and never dropped, and you are mistaken.

> 
> Minus that bug, libavformat.v is but used to do symbol 
> visibility. For which you don't need a verdef, for starters.

Well, make that your lede instead of a dump of a completely useless
report of so-called incompatibilities reported by a tool that does not
know the specifics.

Even better, submit it as an actual patch explaining why and after
checking it does not break anything else.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-07-23 14:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23 13:23 Jan Engelhardt
2022-07-23 13:28 ` Nicolas George
2022-07-23 14:03   ` Jan Engelhardt
2022-07-23 14:32     ` Nicolas George [this message]
2022-07-23 17:36       ` Jan Engelhardt
2022-07-23 17:39         ` Nicolas George
2022-07-23 20:36     ` Jean-Baptiste Kempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtwGeaYM7b3UUHoc@phare.normalesup.org \
    --to=george@nsup.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git