From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7D8DA43BA9 for ; Wed, 20 Jul 2022 09:01:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E17B168B6CC; Wed, 20 Jul 2022 12:01:11 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34F9F68A6B5 for ; Wed, 20 Jul 2022 12:01:06 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 26K914Vc005045 for ; Wed, 20 Jul 2022 11:01:05 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id C7927EB5B9; Wed, 20 Jul 2022 11:01:04 +0200 (CEST) Date: Wed, 20 Jul 2022 11:01:04 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20220709043142.2228184-1-amirmazz@google.com> MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 20 Jul 2022 11:01:05 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH] Make implicit void pointer cast explicit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6488962283748642242==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6488962283748642242== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PHcYgdEI346ah15Z" Content-Disposition: inline --PHcYgdEI346ah15Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Amir Mazzarella (12022-07-19): > I understand that FFmpeg does not contain accommodations, but in my > opinion it is less of an accommodation and more for readability, avoiding > an implicit cast. An explicit void pointer cast, like the one presented in The arguments against useless casts have been worded a thousand times, let us not waste everybody's energy with one more. > my patch, is done elsewhere in FFmpeg code as well. > See https://github.com/FFmpeg/FFmpeg/blob/master/libavutil/hwcontext_qsv.= c#L316 It is not the only coding style inconsistency around this line. Coding style inconsistencies cannot be considered precedents. Regards, --=20 Nicolas George --PHcYgdEI346ah15Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmLXxE4ACgkQcZVLI8pN xgyItQ/9GcQIVKJjElCwg2dmC6NJIWL0+7wVxGH6+hv4jZDnfSAvv9436RUEA5wE wx3nEMdV9IQHpSEJocQmYuwVIMnDn05iTZmht4UbK8xr+0cvBjbTUSdJg71uAM/l AaBb+g7JZYl+cqkElTy2iGSZpPP8c43XhhkGIKajg7QzNhD+mlpQ3hyhhkq1YbhC hs84yruOj9MWG/fup4WXXd0htGh89EoquuSg/enYCsaSVIDaLHpRRfqB9X6H/Cwx oCQrdOV2u619MTO0qEGRyJ8BSpGFgFORKp8NxYwMndO0HzGUykxj8TlsSVXSsxti VOL5e/2Z2/F1TqRgwKHsJOgOObSbRIxyfvc8ElQ0VHdZcYRJykVdIVAr6LjSbWAy 7HZN6guR4ZUfliF3xU1MPw4St2cQV7pQvrTQVDhy/3OsIb/szNfeTklohpAZHCma cTMm7n+nKgX6ePhUG3HpxxpEqGx9nehxxJ8/VN/x9ofWkaVWrVoVLPxnZQKjITpm 8j+3mH33dNTiWncAqhEbt+JJm7L6O2k/4IsnpeOql5uMkjnmLFaCw4152X/BWy73 S/UDcdV1l63QJ3m8gkptFKjJzdwEslvrY42ZbaYd+Me2p0cFqWfFbEP7E5fFo1xW cdLV2hKZOlC1FfWk+8w+dzZDQE1Koomu0ronHqw1K1q3jxnfCDI= =uNR1 -----END PGP SIGNATURE----- --PHcYgdEI346ah15Z-- --===============6488962283748642242== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6488962283748642242==--