Amir Mazzarella (12022-07-19): > I understand that FFmpeg does not contain accommodations, but in my > opinion it is less of an accommodation and more for readability, avoiding > an implicit cast. An explicit void pointer cast, like the one presented in The arguments against useless casts have been worded a thousand times, let us not waste everybody's energy with one more. > my patch, is done elsewhere in FFmpeg code as well. > See https://github.com/FFmpeg/FFmpeg/blob/master/libavutil/hwcontext_qsv.c#L316 It is not the only coding style inconsistency around this line. Coding style inconsistencies cannot be considered precedents. Regards, -- Nicolas George