From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Make implicit void pointer cast explicit
Date: Wed, 20 Jul 2022 11:01:04 +0200
Message-ID: <YtfEUHVNkqJnBLsw@phare.normalesup.org> (raw)
In-Reply-To: <CAMMoCOdZ+emDBACfMk5au3XbNhF7eTDb-rbkPoztAwabkHzK1A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 691 bytes --]
Amir Mazzarella (12022-07-19):
> I understand that FFmpeg does not contain accommodations, but in my
> opinion it is less of an accommodation and more for readability, avoiding
> an implicit cast. An explicit void pointer cast, like the one presented in
The arguments against useless casts have been worded a thousand times,
let us not waste everybody's energy with one more.
> my patch, is done elsewhere in FFmpeg code as well.
> See https://github.com/FFmpeg/FFmpeg/blob/master/libavutil/hwcontext_qsv.c#L316
It is not the only coding style inconsistency around this line. Coding
style inconsistencies cannot be considered precedents.
Regards,
--
Nicolas George
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-20 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 4:31 Amir Mazzarella
2022-07-19 18:32 ` Amir Mazzarella
2022-07-19 19:08 ` Nicolas George
2022-07-19 21:21 ` Amir Mazzarella
2022-07-19 21:23 ` Hendrik Leppkes
2022-07-19 21:23 ` Nicolas George
2022-07-19 22:12 ` Amir Mazzarella
2022-07-20 9:01 ` Nicolas George [this message]
2022-07-28 14:11 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtfEUHVNkqJnBLsw@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git