From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 858284393E for ; Sun, 3 Jul 2022 13:42:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E436A68B9E3; Sun, 3 Jul 2022 16:42:24 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB63468B9D5 for ; Sun, 3 Jul 2022 16:42:18 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 263DgH2s017163 for ; Sun, 3 Jul 2022 15:42:18 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id E6610E00E9; Sun, 3 Jul 2022 15:42:17 +0200 (CEST) Date: Sun, 3 Jul 2022 15:42:17 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <26b9554f-38d0-af5e-a124-8848f57f25b3@passwd.hu> MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sun, 03 Jul 2022 15:42:18 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1432410212790038340==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1432410212790038340== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1EJTykg62381+/Ir" Content-Disposition: inline --1EJTykg62381+/Ir Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Steven Hartland (12022-07-02): > I'm using concat to join multiple files from a GoPro camera including the > three metadata streams, with the early return it fails as the metadata > stream information is missing so map fails. > I believe the reason for the failure is that this early return prevents t= he > metadata from being preserved. You are trying to trick concat into merging files with different streams and match streams between them. It is not how concat is designed to work, it might work in your particular test case but will not work in more complex cases and will break other use cases. For example, with your change, if you concatenate a file with metadata "start_time=3D12:00" and another with "start_time=3D12:01", it will generate a file with both metadata entries instead of just the first one as would be desirable. Implementing your feature is not completely trivial: look how it is done for subtitles streams in DVD structures. The concat stream defines all the streams it expects to find in the file and specifies a condition to match them, "exact_stream_id". > On Sun, 19 Jun 2022 at 21:18, Marton Balint wrote: Please remember that top-posting is forbidden on this mailing-list. If you do not know what it mean, look it up. Regards, --=20 Nicolas George --1EJTykg62381+/Ir Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmLBnLgACgkQcZVLI8pN xgz9uA/8DA82vSIhm7rHfJa/qYrW7Q2psa4uD3Zutt4jehHO31BwU6OKicUOIn3T RNf+C9KBrPgb64KEteFWzQUzGG04374alo4II4yn6M+FP7WcViYYwMhZX3FOHcXy fW3JrFo8O7VV14sBOWlvwetfUHSyfbE9hrlYua8QRAUfnYJQP1kTKHKnVFd56oKM q4Twb/JdziJOFV3zBwGNEynr8qbJHwtNxw/7iCBoC3R1ILTvFqDIhhq1Q90nVA// Rj9RVxAHsaV/GgGMOYY2WWypYy0YcVXFLpVEPgH8dCW4naHtdMztoh3ejISVBR3L k+kav2Ye8KTTdBOT11Djs2o6iOpM9kMxG6B2R5VMZ8MfSQew1rOEy5oilc8IOJB9 jL/I4WV0jikbw1poTPuQ1VarqcMMiGBzIDR3A3RplE9xQGWl4z7W2FQ2uVIa45wY bJew5H28VRThYpHwNr1VoUHPWkxrw5AC7HqYijoHSUVOOSJgZaZRV56AAsnuB43j A3jGfhZES4u74UAWahf9I5RBZz6Ui3+4iSmdpg4+iLxmXndOlXOGBzMcCCF9HZWg DRnI44l+k+j/cjU6fEb2/eu4dX83cp81EznJJNGthW2OSwIo73inULxgHRGSSdNa JSvHSEQroD0k0K9b1DjV/UuhC+VEr2SKlmE2mNtxRDqFjj0xSLI= =VpgK -----END PGP SIGNATURE----- --1EJTykg62381+/Ir-- --===============1432410212790038340== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1432410212790038340==--