From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BBF464393F for ; Sun, 3 Jul 2022 13:28:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8466468B9CE; Sun, 3 Jul 2022 16:28:06 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 58A9768B89E for ; Sun, 3 Jul 2022 16:27:59 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 263DRwIW016093 ; Sun, 3 Jul 2022 15:27:58 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 7E188E00E9; Sun, 3 Jul 2022 15:27:58 +0200 (CEST) Date: Sun, 3 Jul 2022 15:27:58 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20220703125714.1230-1-tong1.wu@intel.com> <20220703125714.1230-3-tong1.wu@intel.com> MIME-Version: 1.0 In-Reply-To: <20220703125714.1230-3-tong1.wu@intel.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sun, 03 Jul 2022 15:27:58 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an auto hwmap filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Tong Wu Content-Type: multipart/mixed; boundary="===============2936067129292903370==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2936067129292903370== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6YCMM5ocxMnb61p2" Content-Disposition: inline --6YCMM5ocxMnb61p2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Tong Wu (12022-07-03): > When two formats lists cannot be merged, a scale filter is > auto-inserted. However, when it comes to hardware map, we have to > manually add a hwmap filter to do the conversion. This patch introduces > an auto hwmap filter to do the hwmap conversion automatically and > modifies the negotiation structures, making it extensible for more auto > filters. >=20 > Signed-off-by: Tong Wu > --- > libavfilter/avfiltergraph.c | 183 ++++++++++++++++++++++++------------ > libavfilter/formats.c | 26 ++++- > libavfilter/formats.h | 9 +- > 3 files changed, 150 insertions(+), 68 deletions(-) Hi, thanks for the patch. It looks a bit hard to review due to the amount of moved code. Can you split the patch into two: (1) moving and reindenting the code into an auxiliary function without functional changes and (2) adding the feature you wanted to add, please? To do that without too much hassle, I would: first, start again from a new branch, make the "move to a function" commit; second, take the code with the extra feature from the other branch and let git turn it into a commit; third, clean up that commit. Thanks in advance. --=20 Nicolas George --6YCMM5ocxMnb61p2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmLBmVwACgkQcZVLI8pN xgy0JxAAsZffpk63fzWbzyYDq9n8+bdXj+FNpvzlcwzMqx5hdAhC2fim3EqoBNw6 bQcdjcVLzFVv0O7gl8s81fPt7HUTFU1JAkozSdUZSBfa2DSE3VDiVF2rV/ruY0P2 i2Xv4vwb5aAAuR6jfmpE3BH4xTE4NCdXO5L7C+RCwZxOxl6j6rR8lULKrZc2wPLJ a1sYA2XeHbp93Fk+8YJcVW8F2NgQeyeiSIauk4a4I30Cjzi1p9syKDFDl3DV+x5Y abM7oNbzUvNhM+9gvf49v6CymS3tUkUyZS6vKB+SdqMhJ0GOAF12vl9m9acNpG42 GJbU9iKul/6W/DtiV4zmrjtlQMaytiBLam3pjrXsI6pGZiDhYjuvAquNSCOzWBzB aguPT40jR1sAhXFmsA6nn3tlLoe7yz0lnUBKGJVF1MH5POSSDGv5a50FPZ/byyq9 AnnzsNc8fcxoTyIHZYwzHztTQfNIs6xmg96EEcOd4FN50mrLyrrN1SfOss3ihPx2 2xrYa/FwoIcDTPIKtcF/BOnf5L2bNuxAelyJtHAXxnC31t1YLDVBqqAnIqMKyzqJ UpZtVJeApZJPanLCpOG+71mmfMsAdxx5BQFnrvP19SwRK5cB0c1DFXXMWcg1ETHl +qq/SKN3c0gE+bNctDvCTsDTEUDegbSiKGxEAIsg9ue3VF4lX6g= =kgs5 -----END PGP SIGNATURE----- --6YCMM5ocxMnb61p2-- --===============2936067129292903370== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2936067129292903370==--