Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an auto hwmap filter

[Nicolas George <george@nsup.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1241 bytes --]

Tong Wu (12022-07-03):
> When two formats lists cannot be merged, a scale filter is
> auto-inserted. However, when it comes to hardware map, we have to
> manually add a hwmap filter to do the conversion. This patch introduces
> an auto hwmap filter to do the hwmap conversion automatically and
> modifies the negotiation structures, making it extensible for more auto
> filters.
> 
> Signed-off-by: Tong Wu <tong1.wu@intel.com>
> ---
>  libavfilter/avfiltergraph.c | 183 ++++++++++++++++++++++++------------
>  libavfilter/formats.c       |  26 ++++-
>  libavfilter/formats.h       |   9 +-
>  3 files changed, 150 insertions(+), 68 deletions(-)

Hi, thanks for the patch. It looks a bit hard to review due to the
amount of moved code.

Can you split the patch into two: (1) moving and reindenting the code
into an auxiliary function without functional changes and (2) adding the
feature you wanted to add, please?

To do that without too much hassle, I would: first, start again from a
new branch, make the "move to a function" commit; second, take the code
with the extra feature from the other branch and let git turn it into a
commit; third, clean up that commit.

Thanks in advance.

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".