Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: "zhangxiong \(A\)" <zhangxiong3@huawei.com>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffprobe.c: Add new Function: The peak bit rate of video streams can be queried
Date: Thu, 23 Jun 2022 16:33:28 +0200
Message-ID: <YrR5uE1LExWeHP6t@phare.normalesup.org> (raw)
In-Reply-To: <ef03e136a20f4d78bc6aebd5f505cdb8@huawei.com>


[-- Attachment #1.1: Type: text/plain, Size: 1023 bytes --]

Wujian(Chin) (12022-06-23):
> Code Process
> - Calculate the frame rate first
> - Obtain the maximum value of the total bytes of all packets according to the number of frames per second
> 
> Signed-off-by: wujian_nanjing <wujian2@huawei.com>
> ---
>  fftools/ffprobe.c                                  | 24 ++++++++++++++++++++++
>  tests/ref/fate/concat-demuxer-extended-lavf-mxf    |  2 +-
>  .../ref/fate/concat-demuxer-extended-lavf-mxf_d10  |  2 +-
>  tests/ref/fate/concat-demuxer-simple1-lavf-mxf     |  2 +-
>  tests/ref/fate/concat-demuxer-simple1-lavf-mxf_d10 |  2 +-
>  tests/ref/fate/flv-demux                           |  2 +-
>  tests/ref/fate/mov-zombie                          |  2 +-
>  tests/ref/fate/ts-small-demux                      |  2 +-
>  8 files changed, 31 insertions(+), 7 deletions(-)

I see no documentation update. It is necessary, including the XML
schema.

Please take care to document over what period the bit rate is computed.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-06-23 14:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23 13:45 Wujian(Chin)
2022-06-23 14:33 ` Nicolas George [this message]
2022-06-25  3:01 Wujian(Chin)
2022-06-27  8:01 ` Nicolas Gaullier
2022-06-27  8:28   ` [FFmpeg-devel] 答复: " Wujian(Chin)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrR5uE1LExWeHP6t@phare.normalesup.org \
    --to=george@nsup.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=zhangxiong3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git