From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] avutil/frame: add av_frame_replace
Date: Tue, 7 Jun 2022 14:18:42 +0200
Message-ID: <Yp9CIjZFlQtIEqou@phare.normalesup.org> (raw)
In-Reply-To: <20220607120247.1666-1-jamrial@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 515 bytes --]
James Almer (12022-06-07):
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavutil/frame.c | 132 ++++++++++++++++++++++++++++++++++++++++++++++
> libavutil/frame.h | 13 +++++
> 2 files changed, 145 insertions(+)
I do not like having a new function without anything that uses it. It
results in several cases in a function that is not really useful because
of a small design flaw. Can you update other parts of the code to make
use of the new function?
Regards,
--
Nicolas George
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-06-07 12:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 15:28 [FFmpeg-devel] [PATCH] " James Almer
2022-06-05 15:42 ` Andreas Rheinhardt
2022-06-05 15:52 ` James Almer
2022-06-05 17:44 ` [FFmpeg-devel] [PATCH v2] " James Almer
2022-06-07 10:21 ` Anton Khirnov
2022-06-07 11:39 ` James Almer
2022-06-07 11:47 ` Anton Khirnov
2022-06-07 12:02 ` [FFmpeg-devel] [PATCH v3] " James Almer
2022-06-07 12:18 ` Nicolas George [this message]
2022-06-07 12:22 ` James Almer
2022-06-07 12:23 ` Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp9CIjZFlQtIEqou@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git