From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DDF094115A for ; Wed, 16 Mar 2022 20:08:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2A0C68B08A; Wed, 16 Mar 2022 22:08:55 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E75FC6800EA for ; Wed, 16 Mar 2022 22:08:53 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 22GK8qxA001699 for ; Wed, 16 Mar 2022 21:08:52 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 20EAFE62AD; Wed, 16 Mar 2022 21:08:52 +0100 (CET) Date: Wed, 16 Mar 2022 21:08:52 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20220309172200.858111-1-onemda@gmail.com> MIME-Version: 1.0 In-Reply-To: <20220309172200.858111-1-onemda@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 16 Mar 2022 21:08:52 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5741339567392964094==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5741339567392964094== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/82/xI2BEvRrAfsb" Content-Disposition: inline --/82/xI2BEvRrAfsb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Paul B Mahol (12022-03-09): > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/src_avsynctest.c | 399 +++++++++++++++++++++++++++++++++++ > 3 files changed, 401 insertions(+) > create mode 100644 libavfilter/src_avsynctest.c I opposed to this patch the first time, on the basis that our existing sources (testsrc and sine) would do the job just as well, and you never bothered to explain what this particular version would bring. I have found out on my own and therefore withdraw my objection. >=20 > +static int32_t sin32(int32_t x, int shift) > +{ > + const double pi =3D M_PI; > + const int32_t a =3D ((2.0 * pi) * (1 << 24)); > + const int32_t b =3D (1 << 7) * (12.0 / pi - 1.0 - pi) * (1 << 24); > + const int32_t c =3D (1 << 9) * 3.0 * (2.0 + pi - 16.0 / pi) * (1 << = 24); > + int64_t x2, result; > + int32_t t1, t2; Can you consider reuse the code from asrc_sine to generate a bit-exact sin table? Regards, --=20 Nicolas George --/82/xI2BEvRrAfsb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmIyQ9IACgkQcZVLI8pN xgxxlBAAs2JNSa22sgUJRVomA5RinG0gTjSeL9VylzxebojHOSIg5anGWuyMnO/n QGi/zRKLnfO1ICRnHQC2YQKp6MuNO5cRrNwGyf803cl9W6B3zgA9Iu0/9Ia0t2SW RTmEr/FKg/6gg9578DtEqoSCLoTo6qh5ihKSEOainD2MY+GxHzaa0xigfWID+nkq Cs6MAefBvp241qJ0mcASFVtx+uu8fXYMc8qStUWBiUrSQxRLmf7N5VZB+xZapuC7 mvYTtyS9WuYHanaOKD4p61O7/t6nAfl5NgCTxgY66i6ste7ERb8QkJwfKMNF3UCD dK4AfboUzLeT6Ji64eOcf8UtiC9X80ewRka5rYW3sp5AuZm79FpBnhvszGPev2aZ YB6iEHGTnamam8EW1MDXK1UOWEQMoQJL5UrM99ijlFHDspTMlX0+vghE4tGbPsvi 2PbuxZZjXRC2o9mOObR8eUv4vvOEznLjCxsgkAC2QoCoB2RfELYhjRB2dL3coI1u N9BKffhuY78Pa9O553GgXZU3P0Xk1DCAnYQ7LSG2/XRMNnBSZHNv7LZ7ERsIm0RY 2T3o3jrTFMWjcW4aZHXy8KvtJpfEGXOvKsUHU1WmOpkzn7qr1mItYO7IDgqgqKEY 0E4bR5DFvPAdHU3g5k78s17/4yoLbV8z9aWr/NBOPC1FRGdKNSE= =1nwY -----END PGP SIGNATURE----- --/82/xI2BEvRrAfsb-- --===============5741339567392964094== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5741339567392964094==--