From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2058F40AA3 for ; Sun, 6 Mar 2022 14:08:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A27A68B101; Sun, 6 Mar 2022 16:08:43 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C94D680064 for ; Sun, 6 Mar 2022 16:08:37 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 226E8a4k023815 for ; Sun, 6 Mar 2022 15:08:36 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 3CDB3E62AD; Sun, 6 Mar 2022 15:08:36 +0100 (CET) Date: Sun, 6 Mar 2022 15:08:36 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20220301132720.86396-1-onemda@gmail.com> MIME-Version: 1.0 In-Reply-To: <20220301132720.86396-1-onemda@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sun, 06 Mar 2022 15:08:36 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5312308914441420410==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5312308914441420410== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GuBxBhZTdNwx6nij" Content-Disposition: inline --GuBxBhZTdNwx6nij Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Paul B Mahol (12022-03-01): > Signed-off-by: Paul B Mahol > --- >=20 > Fix possible hangs if (a)split filter is used in graph and one of outputs= ends > earlier than others. > Then filter may never receive EOF from input provided by (a)split filter. >=20 > See ticket #9152 for commands how to reproduce issue. >=20 > --- > libavfilter/split.c | 68 +++++++++++++++++++++++++++++++++------------ > 1 file changed, 51 insertions(+), 17 deletions(-) Ok, the problem is in forward_status_change() in avfilter.c: it makes a request on the first output, that triggers the status change on the input, and therefore it considers itself satisfied without making a request on the other outputs. It could be changed to make at least one round and requesting on each output, but it would be inefficient for filters that have several outputs connected to different inputs, and that is a more common case. Therefore, I agree, filters with several outputs connected to the same input like split need a real activate implementation. Patch ok, I did not look very carefully at the code itself. Can you disclose why it was so urgent to push a fix for a but seven months old that you would rather be rude than wait a few days? --=20 Nicolas George --GuBxBhZTdNwx6nij Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmIkwGIACgkQcZVLI8pN xgz5AQ/8D5IlN+PatNopNFdK+9MKKBrxAXpUg2YvB/A48DPV/EEjyGII1FDX8e6y qYz6rc59zTnmnH/2jRPFZNaNwI86+zCoHbBRtB8P9WgiEnUHr7crxZp9u8gVyS3E gPKDiOdHGQzkJrCqwRqQxrvw/tAAejTf1E0B0g44STVcMlV6yUMm71++nX6q12q1 o6iHClWJTMjX7CP2u3hClf9Bc7Nt31dxl4b8erIHNgRe1w4LcCs6MNAKOCR+p0s8 xOkV3dYUVTGNzrnMtBawvMtRwo15RdEFn8sQYP5exp3wNdoXt1ud5R/u8ZZLn3jC oGQFwYa896K6f4iCEgvkIpsoS/46amlTsTCcJsqjfHeG03bmP9GIltZn2Mekb9tg TRP+JZPCukpKh02HOYJQmcUFZ3ogDav/4HXtnzNr5sRhGeUhCReooTOz3QDBt04K erJ2GfYMc1epsDFOykJ3457+Zz/vgOgF7VC7uVE44vIvChnYY084yzldvAh/Gttw p4XWCCQ90ZUQAmgQOTHARnW0J7vJsP+rxH7wYsgJhCzThc0oBtPS+4rpyZjrGSeP xQ24YHEQTthOuZp/Zp3aOHwDf/y3Fyy/6pwDPymrLeE28EVhwU7vb37dMKFuEwqW ld/nCAS4GucfioDE0wCIYu4DsFVWwiZykM5yO6O7i80BEYpYbv8= =RAjs -----END PGP SIGNATURE----- --GuBxBhZTdNwx6nij-- --===============5312308914441420410== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5312308914441420410==--