From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EA006422FE for ; Thu, 3 Mar 2022 18:37:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF73768AFD0; Thu, 3 Mar 2022 20:37:39 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 15C5768AB48 for ; Thu, 3 Mar 2022 20:37:33 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 223IbWgT018996 for ; Thu, 3 Mar 2022 19:37:32 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 3AB21E62AD; Thu, 3 Mar 2022 19:37:32 +0100 (CET) Date: Thu, 3 Mar 2022 19:37:32 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20220302184023.285022-1-george@nsup.org> <20220302184023.285022-5-george@nsup.org> MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Thu, 03 Mar 2022 19:37:32 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH 5/5] tests: add coverage for libavfilter's format negotiation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4517095821842584596==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4517095821842584596== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EGxF2aTAh2lKsikC" Content-Disposition: inline --EGxF2aTAh2lKsikC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable James Almer (12022-03-03): > No need to add a fate-libavfilter-negotiation target until there are more > such tests. Thanks for the review. I know these targets are not necessary, but I want them. I do intend to write more tests: >> This is not to be the only test, I intend to cover all the logic in >> pick_format() and the logic in swap_*(). And having submodule-specific fate targets is convenient even if there are only one test. Please read the code assuming there are several tests, including tests using aresample rather than scale. Regards, --=20 Nicolas George --EGxF2aTAh2lKsikC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmIhCuoACgkQcZVLI8pN xgzEKA//eKuhHZm9FyhMW5g1vntyFyq197vPzUuZVHxe9LRf2mdmbEBdM7vvwHr9 HBbFWNo5xHbRMbCSh26ve6RgBlu6wlLr6XvhLhneh34zLWUNVVDbe9ILH2r9PvkL 0wa0nwdUQd6Az+qOInDkpYKSEHIHCdSlkHwrlzdyTuG9TKEdeybfjcYNbj2LV7LD LmlB4ibAcDK64Ulp6PCQFLBaVU8MQ7z/QOuFkTtF9n5tr3N4kL2eNq8Xf7NMhpHc 7qnVtrsqDLNdIUJ1QS7AtFkp8iXkJzZtQdFT6ptXkvw8waLHO9GGHJVV5ys2b0Uj B/0lb/Xg1yhCZpbFTa3R1NOsGO/xeetsrnyVW5Q0LXUW5IUBHpBICPnFdY08UXkK snxp7SZnRHm3n1n9KzmzAXPP3auZch4NJ4NhDf+BopJGrFKzCws/adhcRuFjepZ+ wcMBvoTl0eLYlU6lO4JGBEQBY7u1cfp7cvrn4q627VkI/KHL1peo43rxURTQCzcW MV6xyox8+IEgAnvxfvkKw+F4m8kYiKY/Yc7lUlnqQfiuC7VUNXUA4vUMFswdtLmS lqcV3B0U8uNc9+BBSC6+N1JPjs1cP4qhQBv/z2nZ5c+oacA4xTY4m2u4kb7BdfLG RSb9voxUEVHIhjrHiGV2k+ON4dHFd0dhZ6QEkRQgDoXVCAFaLgA= =tV5j -----END PGP SIGNATURE----- --EGxF2aTAh2lKsikC-- --===============4517095821842584596== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4517095821842584596==--