From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl
Date: Thu, 24 Feb 2022 14:46:40 +0100
Message-ID: <YheMQEnu2GJtxt54@phare.normalesup.org> (raw)
In-Reply-To: <f91a78d1-df9e-55b9-0c77-1fa4a9a32bdf@mail.de>
[-- Attachment #1.1: Type: text/plain, Size: 546 bytes --]
Thilo Borgman (12022-02-24):
> Both LGTM.
Does it?
The way I remember it, this condition was for the initial assembly, as a
temporary measure. I might have missed some steps, but I do not remember
we adopted this as a constant rule.
I see several flaws with it:
- Documentation patches were not counted, now they are.
- Cosmetic patches are counted.
- It does not take the size of the changes.
Using an imperfect solution for bootstrap is one thing, using it
permanently is another.
Regards,
--
Nicolas George
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-24 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 1:49 J. Dekker
2022-02-16 1:49 ` [FFmpeg-devel] [PATCH 2/2] mailmap: update entry J. Dekker
2022-02-24 13:18 ` [FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl Thilo Borgmann
2022-02-24 13:46 ` Nicolas George [this message]
2022-03-01 11:17 ` J. Dekker
2023-02-08 15:50 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YheMQEnu2GJtxt54@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git