* [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output @ 2022-02-19 1:00 Paul B Mahol 2022-02-19 13:58 ` Nicolas George 0 siblings, 1 reply; 3+ messages in thread From: Paul B Mahol @ 2022-02-19 1:00 UTC (permalink / raw) To: ffmpeg-devel Fixes OOM in #9081. Signed-off-by: Paul B Mahol <onemda@gmail.com> --- libavfilter/vf_fps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_fps.c b/libavfilter/vf_fps.c index 99e679441e..1a68d519fb 100644 --- a/libavfilter/vf_fps.c +++ b/libavfilter/vf_fps.c @@ -351,7 +351,7 @@ static int activate(AVFilterContext *ctx) if (s->frames_count > 0) { ret = write_frame(ctx, s, outlink, &again); /* Couldn't generate a frame, so schedule us to perform another step */ - if (again) + if (again && ff_outlink_frame_wanted(outlink)) ff_filter_set_ready(ctx, 100); return ret; } -- 2.33.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output 2022-02-19 1:00 [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output Paul B Mahol @ 2022-02-19 13:58 ` Nicolas George 2022-02-19 16:03 ` Nicolas George 0 siblings, 1 reply; 3+ messages in thread From: Nicolas George @ 2022-02-19 13:58 UTC (permalink / raw) To: FFmpeg development discussions and patches [-- Attachment #1.1: Type: text/plain, Size: 306 bytes --] Paul B Mahol (12022-02-19): > Fixes OOM in #9081. > > Signed-off-by: Paul B Mahol <onemda@gmail.com> > --- > libavfilter/vf_fps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This would break input-driven filtering I think. I am looking into it. Regards, -- Nicolas George [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output 2022-02-19 13:58 ` Nicolas George @ 2022-02-19 16:03 ` Nicolas George 0 siblings, 0 replies; 3+ messages in thread From: Nicolas George @ 2022-02-19 16:03 UTC (permalink / raw) To: FFmpeg development discussions and patches [-- Attachment #1.1: Type: text/plain, Size: 290 bytes --] Nicolas George (12022-02-19): > This would break input-driven filtering I think. I am looking into it. See: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293240.html https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293241.html Regards, -- Nicolas George [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-19 16:03 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-19 1:00 [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output Paul B Mahol 2022-02-19 13:58 ` Nicolas George 2022-02-19 16:03 ` Nicolas George
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git