From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AAE7D42255 for ; Tue, 1 Mar 2022 12:18:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0500168B27E; Tue, 1 Mar 2022 14:18:51 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 247A268B277 for ; Tue, 1 Mar 2022 14:18:44 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 221CIgBJ011162 for ; Tue, 1 Mar 2022 13:18:43 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id C71A8E62AD; Tue, 1 Mar 2022 13:18:42 +0100 (CET) Date: Tue, 1 Mar 2022 13:18:42 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <9B7328D6-3555-4D18-B8F1-78EB362B8358@hotmail.com> MIME-Version: 1.0 In-Reply-To: <9B7328D6-3555-4D18-B8F1-78EB362B8358@hotmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Tue, 01 Mar 2022 13:18:43 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: Add unified_time_base opt X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2460754820552624038==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2460754820552624038== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CJsgcMmb3oLB4v4w" Content-Disposition: inline --CJsgcMmb3oLB4v4w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ye Chuan (12022-03-01): > In some case, the input files have different time base even though > they share the same codec and codec parameters, > While processing the packet, it will adjust the pts/dts by its own > time base instead of the unified one of the output stream, which may > lead to wrong pts/dts or unexpected speed change. >=20 > So this patch add the "unified_time_base" opt, which could be setted by > "-unified_time_base 1" > With the option, it will concatenate the input streams whose time base > are different , and won't course speed change issue. >=20 > Signed-off-by: Chuan Ye > --- > libavformat/concatdec.c | 31 ++++++++++++++++++++++++------- > 1 file changed, 24 insertions(+), 7 deletions(-) Thanks for the patch. I need to examine exactly what it does. In the meantime, I do not know why you keep posting new versions of this patch every few minutes. Please take your time. And before next time: > int segment_time_metadata; > + int unified_time_base; Mangled indentation. Missing documentation. Spelling mistake in the title of the commit message. Regards, --=20 Nicolas George --CJsgcMmb3oLB4v4w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmIeDyAACgkQcZVLI8pN xgzCag/+I4SwSBvLcrlywBbt21esEAd7ucurcTG6+Iy/ZP3pIb0OZogmBvAtfqbR ygRyJfRH83BTOTdxRMpPZNHPQ/zxt3bE8yuHCVUm4DUulmjFlik/YsZNfu9Cdx3w C8RYGYyEj8N4/vLrgIPY79sav5xYjTZCm5KPmkuQ+/y3fQJEPE5An/B8CgJIe7uh 0d+5KCvoK5SnVSmgXnft49SEIGuEbUqG856guDVGGHrkBx8+1kp+2Jd20MMFSieR IuEybpGOPjUhPBsu/6R+txuqVtYivZNFBzwnNQ+Kr5t5G5yUaSkG/j+0mVi3bJqc Bb4/nJsnozVMH2AI6Gap/w6ch29Zp0xPMJnfqR4QWEDkSPp6MRImECRbxENPBeP1 Oi3ZLD3Sscxr/d7hoCXf2Wuq+GmL4IML5GOaf5f8PSXKyUPaZjtPHTO/UKgJmOgO Pr66w6u9lFocsKawEBQ0is3pFXd+o8sYObFZZn7Mpsd0jCLiTLxMtw3oDBZVVVYn iH6thYvAy2xL3oI9HoVqtB/RxdfrmlcasKZ29BqK9pV42V9IBeVO1lqDQg22phDX myrei0BGtmXgxLwZM3jSgUvAZ2I5o+4b6vQvSgDt/6y9x4cgO9Pb4j8hA48I6ncW FaoK1OezXIvjz44U1jZYl1SXGCnJzbBdzATa1x5Vlf9oLe1e/tg= =kDes -----END PGP SIGNATURE----- --CJsgcMmb3oLB4v4w-- --===============2460754820552624038== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2460754820552624038==--