From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EB1ED40E51 for ; Wed, 9 Feb 2022 05:24:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 999FE68B083; Wed, 9 Feb 2022 07:24:35 +0200 (EET) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0EE5468B008 for ; Wed, 9 Feb 2022 07:24:28 +0200 (EET) Received: from cc976dd952578dabee563e248880c159 ([1.136.244.161]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 2195OMJ8009391 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 9 Feb 2022 05:24:26 GMT Date: Wed, 9 Feb 2022 16:24:18 +1100 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Jiasheng Jiang References: <20220207034453.734942-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 In-Reply-To: <20220207034453.734942-1-jiasheng@iscas.ac.cn> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vp6: return value check for av_mallocz X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: multipart/mixed; boundary="===============5982058839576026242==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5982058839576026242== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="moQsD6zAwwq6LfwR" Content-Disposition: inline --moQsD6zAwwq6LfwR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 07, 2022 at 11:44:53AM +0800, Jiasheng Jiang wrote: > As the potential failure of the av_mallocz(), the 's->alpha_context' > could be NULL and be dereferenced later. > Therefore, it should be better to check it and deal with it if fails > in order to prevent memory leak, same as the av_frame_alloc() in > ff_vp56_init(). >=20 > Fixes: 39a3894ad5 ("lavc/vp6: Implement "slice" threading for VP6A decode= ") > Signed-off-by: Jiasheng Jiang > --- > libavcodec/vp6.c | 4 ++++ > 1 file changed, 4 insertions(+) looks good to me. i will apply in couple of days. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --moQsD6zAwwq6LfwR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCYgNQAgAKCRBnYHnFrEDd ay97AKCt5oGvzl0tyOikkad9gTZw6o2F1gCgswP7UyOUtkhFc6qOvpHcrxpYGe4= =mWj/ -----END PGP SIGNATURE----- --moQsD6zAwwq6LfwR-- --===============5982058839576026242== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5982058839576026242==--