From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F8F840E6B for ; Wed, 9 Feb 2022 05:22:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 429B868B00F; Wed, 9 Feb 2022 07:22:41 +0200 (EET) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 285A368AEE0 for ; Wed, 9 Feb 2022 07:22:33 +0200 (EET) Received: from cc976dd952578dabee563e248880c159 ([1.136.242.34]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 2195MNYW008437 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 9 Feb 2022 05:22:27 GMT Date: Wed, 9 Feb 2022 16:22:18 +1100 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Remove always-false check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: multipart/mixed; boundary="===============3026175397502392272==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3026175397502392272== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wV1iWj3Rg3n+rsXP" Content-Disposition: inline --wV1iWj3Rg3n+rsXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 08, 2022 at 04:39:27PM +0100, Andreas Rheinhardt wrote: > Since e9b66175793e5c2af19beefe8e143f6e4901b5df a codec's close > function is never ever called for a codec whose init function has not > been called; in particular, it is never ever called if the > AVCodecContext's private data has not been allocated. >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp8.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c > index a70d94bd82..c9d9117528 100644 > --- a/libavcodec/vp8.c > +++ b/libavcodec/vp8.c > @@ -2826,9 +2826,6 @@ av_cold int ff_vp8_decode_free(AVCodecContext *avct= x) > VP8Context *s =3D avctx->priv_data; > int i; > =20 > - if (!s) > - return 0; > - > vp8_decode_flush_impl(avctx, 1); > for (i =3D 0; i < FF_ARRAY_ELEMS(s->frames); i++) > av_frame_free(&s->frames[i].tf.f); looks good to me. please apply. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --wV1iWj3Rg3n+rsXP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCYgNPhgAKCRBnYHnFrEDd a7J6AJwMiTG+42uXRjyKEuPq/hFBh9lbZQCghQ3RZxIpYeU6iVjMQPnLimjZtIY= =mZGX -----END PGP SIGNATURE----- --wV1iWj3Rg3n+rsXP-- --===============3026175397502392272== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3026175397502392272==--