[FFmpeg-devel] [PATCH] avcodec/vp8: Remove always-false check

[FFmpeg-devel] [PATCH] avcodec/vp8: Remove always-false check

[Andreas Rheinhardt]

Since e9b66175793e5c2af19beefe8e143f6e4901b5df a codec's close
function is never ever called for a codec whose init function has not
been called; in particular, it is never ever called if the
AVCodecContext's private data has not been allocated.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/vp8.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c
index a70d94bd82..c9d9117528 100644
--- a/libavcodec/vp8.c
+++ b/libavcodec/vp8.c
@@ -2826,9 +2826,6 @@ av_cold int ff_vp8_decode_free(AVCodecContext *avctx)
     VP8Context *s = avctx->priv_data;
     int i;
 
-    if (!s)
-        return 0;
-
     vp8_decode_flush_impl(avctx, 1);
     for (i = 0; i < FF_ARRAY_ELEMS(s->frames); i++)
         av_frame_free(&s->frames[i].tf.f);
-- 
2.32.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Remove always-false check

[Peter Ross]

[-- Attachment #1.1: Type: text/plain, Size: 1047 bytes --]

On Tue, Feb 08, 2022 at 04:39:27PM +0100, Andreas Rheinhardt wrote:
> Since e9b66175793e5c2af19beefe8e143f6e4901b5df a codec's close
> function is never ever called for a codec whose init function has not
> been called; in particular, it is never ever called if the
> AVCodecContext's private data has not been allocated.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/vp8.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c
> index a70d94bd82..c9d9117528 100644
> --- a/libavcodec/vp8.c
> +++ b/libavcodec/vp8.c
> @@ -2826,9 +2826,6 @@ av_cold int ff_vp8_decode_free(AVCodecContext *avctx)
>      VP8Context *s = avctx->priv_data;
>      int i;
>  
> -    if (!s)
> -        return 0;
> -
>      vp8_decode_flush_impl(avctx, 1);
>      for (i = 0; i < FF_ARRAY_ELEMS(s->frames); i++)
>          av_frame_free(&s->frames[i].tf.f);

looks good to me. please apply.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".