From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0EAEC40AFB for ; Fri, 4 Feb 2022 01:01:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 272C268B1CD; Fri, 4 Feb 2022 03:01:28 +0200 (EET) Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.163]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 15A9B68AE72 for ; Fri, 4 Feb 2022 03:01:21 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1643936480; s=strato-dkim-0002; d=oneric.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=Pp92Hxc1Gr8bHRxpnTLMPvSMw+f9FzjH3PWLbxDNdGE=; b=kc/zzla+GPbAWEiviudMhF3iAM7/Rrn8mvrAI0Nlu8Y3VYWdCKxWPE+swiVIYBAhWa kU28N21gu3KJCJM99Y7PlsSjvUDXavxiUIQy6U9rcFuwXnm62Q0mwtBLyFlkfkMFzbdM sjzQWoQ+F0jeJS2uCH5d+2sCjlv1xCYcIJ6pVO4b3img8qP+IjBQST7d8iLtHv9Ps/3q jcLYIOdG3Q870KzNXx3NgkLjlTeJmlK+moudf/0quYhN1xGcNy8hw3JYyUzzCQb92qjm ZCXu80loZ9h1FJQRZd7AYABKQDfG46FpcAuFRiYLTxHldckhbPUfrpeg7jytMhAL/8q+ rbQA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":I2IBZ0mrW/AWQXwgB4oxKM1YsW1lFUznrLvi/XReWqAAlWwZ8wlvfXmGs4jUQ0oz8ZbhHexs8fhgUydUc9QhuFabaKc4j13CsW3PRIEq" X-RZG-CLASS-ID: mo00 Received: from debian-buster.desktop by smtp.strato.de (RZmta 47.39.0 AUTH) with ESMTPSA id jfcdcdy1411KQkE (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate) for ; Fri, 4 Feb 2022 02:01:20 +0100 (CET) Date: Fri, 4 Feb 2022 02:01:19 +0100 From: Oneric To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Feb 03, 2022 at 20:51:16 +0000, Soft Works wrote: > I think when you inject that word-joiner as a workaround for ass > parsing, you'll also need to make sure that it gets removed > when encoding to other formats. There's no way of knowing whether the word-joiner comes from a conversion performed by ffmpeg in the past or already existed in the original source. However, the wordjoiner does not alter the visually appearance and is unlikely to change line-breaking properties; that's why I chose a word-joiner. Therefore I don't think removing (only) the inserted word-joiners is possible, but also not necessary. Also, was the wrong \\ recollapsed into a single \ somehwere? If yes, then this code can be dropped as well (but I don't know where it is). My biggest concern with this is the unconditional assumption of UTF-8 in ff_ass_bprint_text_event? Is there a way to improve on this or does ffmpeg convert all text to UTF-8 before it's passed to this function? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".