From: Oneric <oneric@oneric.de>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes
Date: Fri, 4 Feb 2022 02:01:19 +0100
Message-ID: <Yfx63zC353uhxBUw@debian-buster.desktop> (raw)
In-Reply-To: <DM8P223MB03653EF40263AF445A244418BA289@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
On Thu, Feb 03, 2022 at 20:51:16 +0000, Soft Works wrote:
> I think when you inject that word-joiner as a workaround for ass
> parsing, you'll also need to make sure that it gets removed
> when encoding to other formats.
There's no way of knowing whether the word-joiner comes from
a conversion performed by ffmpeg in the past or already existed
in the original source.
However, the wordjoiner does not alter the visually appearance and
is unlikely to change line-breaking properties; that's why I chose
a word-joiner. Therefore I don't think removing (only) the inserted
word-joiners is possible, but also not necessary.
Also, was the wrong \\ recollapsed into a single \ somehwere? If yes,
then this code can be dropped as well (but I don't know where it is).
My biggest concern with this is the unconditional assumption of UTF-8 in
ff_ass_bprint_text_event? Is there a way to improve on this or does ffmpeg
convert all text to UTF-8 before it's passed to this function?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-04 1:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 18:16 Oneric
2022-01-16 18:16 ` [FFmpeg-devel] [PATCH 2/2] avcodec/webvttdec: honour bidi marks Oneric
2022-02-01 17:38 ` [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes Oneric
2022-02-01 19:44 ` Soft Works
2022-02-01 20:06 ` Oneric
2022-02-01 20:41 ` Soft Works
2022-02-01 23:25 ` Oneric
2022-02-02 4:44 ` Soft Works
2022-02-02 17:03 ` Oneric
2022-02-02 22:18 ` Soft Works
2022-02-02 22:44 ` Soft Works
2022-02-03 2:11 ` Oneric
2022-02-03 20:51 ` Soft Works
2022-02-04 1:01 ` Oneric [this message]
2022-02-04 1:30 ` Andreas Rheinhardt
2022-02-04 21:52 ` Oneric
2022-02-04 23:24 ` Soft Works
2022-02-05 1:20 ` Oneric
2022-02-05 2:08 ` Soft Works
2022-02-05 21:59 ` Oneric
2022-02-06 1:08 ` Soft Works
2022-02-06 1:37 ` Soft Works
2022-02-04 1:57 ` Soft Works
2022-02-04 5:34 ` Soft Works
2022-02-04 5:59 ` Soft Works
2022-02-04 6:48 ` Soft Works
2022-02-04 21:19 ` Oneric
2022-02-04 22:23 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfx63zC353uhxBUw@debian-buster.desktop \
--to=oneric@oneric.de \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git