From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F2E304095F for ; Tue, 1 Feb 2022 20:06:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 533CF68B3A9; Tue, 1 Feb 2022 22:06:56 +0200 (EET) Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE72A68B37C for ; Tue, 1 Feb 2022 22:06:49 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1643746009; s=strato-dkim-0002; d=oneric.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=iB88LNSmaA+0cYbHKN2vb0Qb/LiybM3ojGau5jY4sgs=; b=PxkZG78uosFsBKS18OiDQHFWa8J0LgbjiMs085VmPr8yCEzKFQauOkb3cwn7r8IJx0 tZYQkv8ndjeZj+g140j+gUDv1dz5B4q8So8l7zNE+DSqSdV4RaosumoGqpGOuluFtQ5Y m2bHuqjrlUnFKLa9izoyWNKvHWQospCbCXA5rD8u26iNj72kgRzdiZKmp7LwwxplXm9l o1+LtGWbzJNQiU/V3bP/J8e4G8V/NlfKafXv8KEiRVGgGUciPWtaSbrqS+JS24nVxRWw pQm0OuNIPA60O+OcJQYotVJhho5xoITrkfSUcdog0rRbnV0LYrKXLrRV9LtlQrWagh/q H0xg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":I2IBZ0mrW/AWQXwgB4oxKM1YsW1lFUznrLvi/XReWqAAlWwZ8wlvfXmGs4jUQ0oz8ZbhHexs8fhgU3BXINohv1vl1z2ERSTJq87RiReC" X-RZG-CLASS-ID: mo00 Received: from debian-buster.desktop by smtp.strato.de (RZmta 47.39.0 AUTH) with ESMTPSA id jfcdcdy11K6mBPB (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate) for ; Tue, 1 Feb 2022 21:06:48 +0100 (CET) Date: Tue, 1 Feb 2022 21:06:48 +0100 From: Oneric To: FFmpeg development discussions and patches Message-ID: References: <20220116181655.6407-1-oneric@oneric.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Feb 01, 2022 at 19:44:24 +0000, Soft Works wrote: > > On Sun, Jan 16, 2022 at 19:16:54 +0100, Oneric wrote: > > > > In case anyone is wondering why patchwork fails to apply the second patch, > > this is probably once again because the patch updates one of FATE's ASS > > reference files which use CRLF line-endings. > > Locally git am applies both without a hitch for me on top of current master > > (and FATE passes after applying each patch). > > > You can add a .gitattributes file to tests/ref/fate/ which includes the line > > sub-webvtt2 -diff > > Then your local git format-patch will create a binary diff for the file. Thanks for your suggestion. However, a binary diff would look like this which isn't great for seeing what's going on during review: diff --git a/tests/ref/fate/sub-webvtt2 b/tests/ref/fate/sub-webvtt2 index 357b8178ea1cf224ad47dcf78b24f1948ece6665..4cd1d86a9a58ccf65812131bf84a17531c2c6cfa 100644 GIT binary patch delta 24 gcmeys^NnXiIV;bjhJHgMV-r)eM-6?GYgs=70DwpeRR910 delta 18 Zcmeyy^MPkWIV+o?k+F%X+2m%{&j3Hw26O-b Also as noted, locally plain `git am` has no issues applying the regular (non-binary) patch; iirc patchwork uses some additional flags to make it more restrictive because regular codefiles shouldn't use CRLF line-endings. I recall using some .gitattribute settings to force crlf (without making the file binary?) were discussed last time this happened, but deemed to be not worth it because of some other issues with it. > > softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".