From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B9DB1425A5 for ; Wed, 5 Jan 2022 06:18:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 236C368A0EA; Wed, 5 Jan 2022 08:18:52 +0200 (EET) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 31F05680588 for ; Wed, 5 Jan 2022 08:18:46 +0200 (EET) Received: from 301de4447f55623bb5f04e9d71fc65fe ([1.152.187.112]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 2056IXLd015859 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Wed, 5 Jan 2022 06:18:38 GMT Date: Wed, 5 Jan 2022 17:18:29 +1100 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20220101011148.13921-1-jpstewart@personalprojects.net> MIME-Version: 1.0 In-Reply-To: <20220101011148.13921-1-jpstewart@personalprojects.net> Subject: Re: [FFmpeg-devel] [PATCH v2 0/2] avformat/mvdec: make audio stream conditional X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8760647984964395733==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8760647984964395733== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qRaNGNMmaHRLcpPw" Content-Disposition: inline --qRaNGNMmaHRLcpPw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 31, 2021 at 08:11:46PM -0500, John-Paul Stewart wrote: > Changed in v2: > Allocate the audio stream first to maintain consistent behaviour > with prior code. >=20 > Recent discussion on the list led me to realize that libavformat was > unconditionally creating an audio stream for all SGI movie format > (version 2) files, even when no audio is present in the file. =20 >=20 > A sample of a movie file with no audio can be found at > http://www.personalprojects.net/ffmpeg/silent.movie >=20 > Unpatched ffmpeg will report an audio stream even though no audio is > present. After the following patch no audio stream is reported. >=20 > Incidentally, the silent.movie sample above is at 25fps and can also be > used by anyone who wants to double-check the earlier patch 3c9ffbd009 > that reads and sets the framerate. The sample file is only about 88 KB. v2 patchset looks good to me. I will apply in a couple of days. Thanks. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --qRaNGNMmaHRLcpPw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCYdU4MQAKCRBnYHnFrEDd a4EHAJ4nnqE+DUkECmqirHuUuBsjSVRkCQCaA4ucxJXbRrc81pDAGhcdSmuw1RE= =aUJ4 -----END PGP SIGNATURE----- --qRaNGNMmaHRLcpPw-- --===============8760647984964395733== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8760647984964395733==--