* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-08 16:30 [FFmpeg-devel] 5.0 blocking issues Michael Niedermayer
@ 2022-01-08 16:36 ` Romain Beauxis
2022-01-08 18:55 ` Soft Works
` (5 subsequent siblings)
6 siblings, 0 replies; 20+ messages in thread
From: Romain Beauxis @ 2022-01-08 16:36 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Le sam. 8 janv. 2022 à 10:30, Michael Niedermayer
<michael@niedermayer.cc> a écrit :
>
> Hi all
>
> This is a simple go/no go call
> if you know of something that still should go into 5.0 please reply here
> with a list of what you are working on and a timelimit until when you
> will be done with it
>
> if you think everything is ready for the release, then too feel free to
> reply (assuming few others said ok yet) this is not supposed to become a
> 100 reply thread with oks, just maybe 2-3 people confirming that noone
> is aware of things missing.
>
> I intend to do the release within 2-3 days of all "no go" things being
> resolved or timeouting
Hi,
Not sure if that should be blocking but the series of patches starting
here: http://ffmpeg.org/pipermail/ffmpeg-devel/2022-January/290940.html
do fix avfoundation devices, which are currently unusable. It would be
nice to get it out as part of a new release.
I'm available in the coming days for quick review/changes/fixes.
-- Romain
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-08 16:30 [FFmpeg-devel] 5.0 blocking issues Michael Niedermayer
2022-01-08 16:36 ` Romain Beauxis
@ 2022-01-08 18:55 ` Soft Works
2022-01-08 21:31 ` Lynne
` (4 subsequent siblings)
6 siblings, 0 replies; 20+ messages in thread
From: Soft Works @ 2022-01-08 18:55 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> Niedermayer
> Sent: Saturday, January 8, 2022 5:30 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: [FFmpeg-devel] 5.0 blocking issues
>
> Hi all
>
> This is a simple go/no go call
> if you know of something that still should go into 5.0 please reply here
> with a list of what you are working on and a timelimit until when you
> will be done with it
[PATCH v4] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11)
Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-15%2Fsoftworkz%2Fqsv_vpp_regression-v4
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/15
Patchwork: https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.15.v4.ffstaging.FFmpeg.1641538891098.ffmpegagent@gmail.com/
[PATCH] avcodec/dvdsubdec: fix incorrect yellow appearance of dvd subtitles
Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-16%2Fsoftworkz%2Fpatch_dvdsubdec_fix-v1
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/16
Patchwork: https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.16.ffstaging.FFmpeg.1641262759164.ffmpegagent@gmail.com/
Both are completed.
Thanks,
softworkz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-08 16:30 [FFmpeg-devel] 5.0 blocking issues Michael Niedermayer
2022-01-08 16:36 ` Romain Beauxis
2022-01-08 18:55 ` Soft Works
@ 2022-01-08 21:31 ` Lynne
2022-01-10 3:09 ` "zhilizhao(赵志立)"
` (3 subsequent siblings)
6 siblings, 0 replies; 20+ messages in thread
From: Lynne @ 2022-01-08 21:31 UTC (permalink / raw)
To: FFmpeg development discussions and patches
8 Jan 2022, 17:30 by michael@niedermayer.cc:
> Hi all
>
> This is a simple go/no go call
> if you know of something that still should go into 5.0 please reply here
> with a list of what you are working on and a timelimit until when you
> will be done with it
>
> if you think everything is ready for the release, then too feel free to
> reply (assuming few others said ok yet) this is not supposed to become a
> 100 reply thread with oks, just maybe 2-3 people confirming that noone
> is aware of things missing.
>
> I intend to do the release within 2-3 days of all "no go" things being
> resolved or timeouting
>
> thx
>
Go for me.
I'll add a few Vulkan filter entries to the changelog, since
it's incomplete, and I'll mention the default AAC coder
was changed, but those are non-blockers.
j-b wanted to wait on something before announcing the
release, so I won't push my website patch before he pitches
in, but that's independent of tagging the release and making
the signed archives.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-08 16:30 [FFmpeg-devel] 5.0 blocking issues Michael Niedermayer
` (2 preceding siblings ...)
2022-01-08 21:31 ` Lynne
@ 2022-01-10 3:09 ` "zhilizhao(赵志立)"
2022-01-10 9:04 ` lance.lmwang
2022-01-10 10:32 ` "zhilizhao(赵志立)"
2022-01-10 16:55 ` Anton Khirnov
` (2 subsequent siblings)
6 siblings, 2 replies; 20+ messages in thread
From: "zhilizhao(赵志立)" @ 2022-01-10 3:09 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jan 9, 2022, at 12:30 AM, Michael Niedermayer <michael@niedermayer.cc> wrote:
>
> Hi all
>
> This is a simple go/no go call
> if you know of something that still should go into 5.0 please reply here
> with a list of what you are working on and a timelimit until when you
> will be done with it
A regression issue: avformat/movenc: fix duration in mdhd box
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_7D4D80DC34DB3F53572F9D76E0EE5AEE3509@qq.com/
------------------------------------------------------------------------
The following movenc patches may take some time to review, they can be
backported after 5.0 release.
Assert failure issues:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_9373ABED4E3F70552D699AF7400F9A699F08@qq.com/
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_20A6D1A7E4EABB13321C520B8C662F90AA06@qq.com/
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_4C6B9A1C40F19A919F39AB344E6D70062D08@qq.com/
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_763895C15DB500687202E9685A7D2EAE4E0A@qq.com/
Invalid tfra box:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_E47115C78906AEAD65415302C85B53E07305@qq.com/
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_8B85435318484473E3736FB5D029090EBB05@qq.com/
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_4134BB3E1556699C8EE1305B003463801009@qq.com/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-10 3:09 ` "zhilizhao(赵志立)"
@ 2022-01-10 9:04 ` lance.lmwang
2022-01-10 10:32 ` "zhilizhao(赵志立)"
1 sibling, 0 replies; 20+ messages in thread
From: lance.lmwang @ 2022-01-10 9:04 UTC (permalink / raw)
To: ffmpeg-devel
On Mon, Jan 10, 2022 at 11:09:11AM +0800, "zhilizhao(赵志立)" wrote:
>
>
> > On Jan 9, 2022, at 12:30 AM, Michael Niedermayer <michael@niedermayer.cc> wrote:
> >
> > Hi all
> >
> > This is a simple go/no go call
> > if you know of something that still should go into 5.0 please reply here
> > with a list of what you are working on and a timelimit until when you
> > will be done with it
>
> A regression issue: avformat/movenc: fix duration in mdhd box
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_7D4D80DC34DB3F53572F9D76E0EE5AEE3509@qq.com/
https://patchwork.ffmpeg.org/check/48152/
Make fate failed?
make: *** [fate-copy-trac3074] Error 1
make: *** [fate-mov-mp4-disposition-mpegts-remux] Error 1
make: *** [fate-mov-cover-image] Error 1
>
> ------------------------------------------------------------------------
> The following movenc patches may take some time to review, they can be
> backported after 5.0 release.
>
> Assert failure issues:
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_9373ABED4E3F70552D699AF7400F9A699F08@qq.com/
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_20A6D1A7E4EABB13321C520B8C662F90AA06@qq.com/
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_4C6B9A1C40F19A919F39AB344E6D70062D08@qq.com/
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_763895C15DB500687202E9685A7D2EAE4E0A@qq.com/
>
> Invalid tfra box:
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_E47115C78906AEAD65415302C85B53E07305@qq.com/
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_8B85435318484473E3736FB5D029090EBB05@qq.com/
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_4134BB3E1556699C8EE1305B003463801009@qq.com/
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-10 3:09 ` "zhilizhao(赵志立)"
2022-01-10 9:04 ` lance.lmwang
@ 2022-01-10 10:32 ` "zhilizhao(赵志立)"
1 sibling, 0 replies; 20+ messages in thread
From: "zhilizhao(赵志立)" @ 2022-01-10 10:32 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> > A regression issue: avformat/movenc: fix duration in mdhd box
> > https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_7D4D80DC34DB3F53572F9D76E0EE5AEE3509@qq.com/
>
> https://patchwork.ffmpeg.org/check/48152/
>
> Make fate failed?
> make: *** [fate-copy-trac3074] Error 1
> make: *** [fate-mov-mp4-disposition-mpegts-remux] Error 1
> make: *** [fate-mov-cover-image] Error 1
Fixed by v4 which doesn’t reached patchwork yet.
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_C134573E6B56A39D92E0345A0634B9814E09@qq.com/
There are a lot of false positive reports, better be cleanly up afterwards.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-08 16:30 [FFmpeg-devel] 5.0 blocking issues Michael Niedermayer
` (3 preceding siblings ...)
2022-01-10 3:09 ` "zhilizhao(赵志立)"
@ 2022-01-10 16:55 ` Anton Khirnov
2022-01-10 18:12 ` Andreas Rheinhardt
2022-01-12 6:37 ` Lynne
6 siblings, 0 replies; 20+ messages in thread
From: Anton Khirnov @ 2022-01-10 16:55 UTC (permalink / raw)
To: FFmpeg development discussions and patches
The first patch in my just-sent lavf set:
lavf/udp: do not return an uninitialized value from udp_open()
(message-id <20220110165143.2292-1-anton@khirnov.net>)
should go into 5.0 (and 4.4).
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-08 16:30 [FFmpeg-devel] 5.0 blocking issues Michael Niedermayer
` (4 preceding siblings ...)
2022-01-10 16:55 ` Anton Khirnov
@ 2022-01-10 18:12 ` Andreas Rheinhardt
2022-01-12 6:37 ` Lynne
6 siblings, 0 replies; 20+ messages in thread
From: Andreas Rheinhardt @ 2022-01-10 18:12 UTC (permalink / raw)
To: ffmpeg-devel
Michael Niedermayer:
> Hi all
>
> This is a simple go/no go call
> if you know of something that still should go into 5.0 please reply here
> with a list of what you are working on and a timelimit until when you
> will be done with it
>
> if you think everything is ready for the release, then too feel free to
> reply (assuming few others said ok yet) this is not supposed to become a
> 100 reply thread with oks, just maybe 2-3 people confirming that noone
> is aware of things missing.
>
> I intend to do the release within 2-3 days of all "no go" things being
> resolved or timeouting
>
I have just noticed that I forgot to make AVStream.disposition 64bit and
that I have never fixed the undefined behaviour in cmdutils.c (see
https://ffmpeg.org/pipermail/ffmpeg-devel/2021-November/287963.html). I
intend to apply and backport this tonight unless someone disagrees with
this.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-08 16:30 [FFmpeg-devel] 5.0 blocking issues Michael Niedermayer
` (5 preceding siblings ...)
2022-01-10 18:12 ` Andreas Rheinhardt
@ 2022-01-12 6:37 ` Lynne
2022-01-12 16:30 ` Michael Niedermayer
6 siblings, 1 reply; 20+ messages in thread
From: Lynne @ 2022-01-12 6:37 UTC (permalink / raw)
To: FFmpeg development discussions and patches
8 Jan 2022, 17:30 by michael@niedermayer.cc:
> Hi all
>
> This is a simple go/no go call
> if you know of something that still should go into 5.0 please reply here
> with a list of what you are working on and a timelimit until when you
> will be done with it
>
> if you think everything is ready for the release, then too feel free to
> reply (assuming few others said ok yet) this is not supposed to become a
> 100 reply thread with oks, just maybe 2-3 people confirming that noone
> is aware of things missing.
>
> I intend to do the release within 2-3 days of all "no go" things being
> resolved or timeouting
>
> thx
>
Both of elenril and mkver's patches got merged, isn't it
time to tag and make archives already?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-12 6:37 ` Lynne
@ 2022-01-12 16:30 ` Michael Niedermayer
2022-01-12 16:36 ` Nicolas George
2022-01-12 21:35 ` Soft Works
0 siblings, 2 replies; 20+ messages in thread
From: Michael Niedermayer @ 2022-01-12 16:30 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 2509 bytes --]
On Wed, Jan 12, 2022 at 07:37:03AM +0100, Lynne wrote:
> 8 Jan 2022, 17:30 by michael@niedermayer.cc:
>
> > Hi all
> >
> > This is a simple go/no go call
> > if you know of something that still should go into 5.0 please reply here
> > with a list of what you are working on and a timelimit until when you
> > will be done with it
> >
> > if you think everything is ready for the release, then too feel free to
> > reply (assuming few others said ok yet) this is not supposed to become a
> > 100 reply thread with oks, just maybe 2-3 people confirming that noone
> > is aware of things missing.
> >
> > I intend to do the release within 2-3 days of all "no go" things being
> > resolved or timeouting
> >
> > thx
> >
>
> Both of elenril and mkver's patches got merged, isn't it
> time to tag and make archives already?
something is not working efficiently here
There have been more replies here than from elenril and mkver
also there have been over the ML multiple requests for backports
to 5.0 today. (which may or may not be all unimportant)
We do need a better way to detect when a branch is ready for release
or master is ready to be branched.
Iam really bad at keeping track of everything everyone asks to be
included and then notice when it was included fully with nothing
missing and no amendmends.
Maybe we could put a RELEASE_BLOCKER file in release branches in the future
and everyone can list in it what needs to be done before the release
and when something is done the person pushing would also remove that
line from the file.
for 5.0 now, i guess this is a 2nd go/no go call here
anything else that I should wait for ?
if not i will make the release _probably_ in the next 2-3 days or so
(if nothing interferes)
the 2nd thing is i certainly am not able to sit here for weeks and wait
for some "make a release now" bell to ring and then jump and do the release.
i wish i could but thats not something i can do nor is it something
people would want me to do. For example i had a migraine 2 days ago and
it certainly would not be helpfull to the release quality if i made the
release on that day for example.
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If the United States is serious about tackling the national security threats
related to an insecure 5G network, it needs to rethink the extent to which it
values corporate profits and government espionage over security.-Bruce Schneier
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-12 16:30 ` Michael Niedermayer
@ 2022-01-12 16:36 ` Nicolas George
2022-01-12 16:41 ` James Almer
2022-01-12 21:35 ` Soft Works
1 sibling, 1 reply; 20+ messages in thread
From: Nicolas George @ 2022-01-12 16:36 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 819 bytes --]
Michael Niedermayer (12022-01-12):
> Iam really bad at keeping track of everything everyone asks to be
> included and then notice when it was included fully with nothing
> missing and no amendmends.
> Maybe we could put a RELEASE_BLOCKER file in release branches in the future
> and everyone can list in it what needs to be done before the release
> and when something is done the person pushing would also remove that
> line from the file.
Maybe you could stop bothering about things you are not good at and that
bore you.
If releases need to be made, then let somebody step in for the role of
release manager. And if nobody steps in, let us not make releases.
After all, WE do not need to make releases: it is the other projects who
need us to make releases.
Regards,
--
Nicolas George
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-12 16:36 ` Nicolas George
@ 2022-01-12 16:41 ` James Almer
2022-01-12 16:47 ` Nicolas George
2022-01-12 23:17 ` Michael Niedermayer
0 siblings, 2 replies; 20+ messages in thread
From: James Almer @ 2022-01-12 16:41 UTC (permalink / raw)
To: ffmpeg-devel
On 1/12/2022 1:36 PM, Nicolas George wrote:
> Michael Niedermayer (12022-01-12):
>> Iam really bad at keeping track of everything everyone asks to be
>> included and then notice when it was included fully with nothing
>> missing and no amendmends.
>> Maybe we could put a RELEASE_BLOCKER file in release branches in the future
>> and everyone can list in it what needs to be done before the release
>> and when something is done the person pushing would also remove that
>> line from the file.
>
> Maybe you could stop bothering about things you are not good at and that
> bore you.
>
> If releases need to be made, then let somebody step in for the role of
> release manager. And if nobody steps in, let us not make releases.
>
> After all, WE do not need to make releases: it is the other projects who
> need us to make releases.
>
> Regards,
I think it should be more like, as release manager, he decides when to
cut a branch and when to tag a release within that branch, and in either
case giving a warning with some time in advance.
Saying "Anything else?" then waiting for people and constantly
postponing tagging is not going to work. And it's not the first time
this happens.
Right now the branch is made and and the feature set frozen, and
anything that could be backported can wait until 5.0.1. Cutting the
branch is when interested parties should spoke and be hasty as that
means a feature freeze. But right now, the release can and should be
made whenever Michael wants to.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-12 16:41 ` James Almer
@ 2022-01-12 16:47 ` Nicolas George
2022-01-12 17:30 ` Jean-Baptiste Kempf
2022-01-12 23:17 ` Michael Niedermayer
1 sibling, 1 reply; 20+ messages in thread
From: Nicolas George @ 2022-01-12 16:47 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1509 bytes --]
James Almer (12022-01-12):
> I think it should be more like, as release manager, he decides when to cut a
> branch and when to tag a release within that branch, and in either case
> giving a warning with some time in advance.
> Saying "Anything else?" then waiting for people and constantly postponing
> tagging is not going to work. And it's not the first time this happens.
>
> Right now the branch is made and and the feature set frozen, and anything
> that could be backported can wait until 5.0.1. Cutting the branch is when
> interested parties should spoke and be hasty as that means a feature freeze.
> But right now, the release can and should be made whenever Michael wants to.
I agree with that.
My point is more general: Michael takes up the boring tasks that "need"
to be made so that FFmpeg can be considered a "serious" project, even
though he does not enjoy them and he admits he is not good at them.
I consider this a toxic configuration. FFmpeg does not "need" to be a
"serious" project, we just need free time to write beautiful and
efficient code.
It is other projects, projects who use FFmpeg, who need it. We already
give good, free code, and they want more, API stability and backports
and security maintenance. I say: if you want it, pay somebody to do it.
(Not me, I am not interested, that is my point.)
This is reminiscent of the reaction of corporate drones to the log4j
bugs: they expected free maintenance.
Regards,
--
Nicolas George
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-12 16:47 ` Nicolas George
@ 2022-01-12 17:30 ` Jean-Baptiste Kempf
2022-01-12 17:58 ` Nicolas George
0 siblings, 1 reply; 20+ messages in thread
From: Jean-Baptiste Kempf @ 2022-01-12 17:30 UTC (permalink / raw)
To: ffmpeg-devel
On Wed, 12 Jan 2022, at 17:47, Nicolas George wrote:
> I consider this a toxic configuration. FFmpeg does not "need" to be a
> "serious" project, we just need free time to write beautiful and
> efficient code.
Are you _sure_ this is an opinion that is shared by the majority of contributors on this mailing list?
Quite a few FFmpeg contributors are paid by companies and the popularity of FFmpeg is largely due to its pragmaticism and solving real-case scenarios by users and companies. Aka "serious project" and "working code", not "beautiful code".
There are many academics/research/fun closed/open projects on multimedia that focus on fun and beautiful.
But I don't think FFmpeg is the best one for this.
As for the release management, I would understand that Michael want to stop doing it, but Michael needs to say that explicitly and maybe someone wants to step up to take this task.
Best,
--
Jean-Baptiste Kempf - President
+33 672 704 734
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-12 16:41 ` James Almer
2022-01-12 16:47 ` Nicolas George
@ 2022-01-12 23:17 ` Michael Niedermayer
1 sibling, 0 replies; 20+ messages in thread
From: Michael Niedermayer @ 2022-01-12 23:17 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 2536 bytes --]
On Wed, Jan 12, 2022 at 01:41:18PM -0300, James Almer wrote:
>
>
> On 1/12/2022 1:36 PM, Nicolas George wrote:
> > Michael Niedermayer (12022-01-12):
> > > Iam really bad at keeping track of everything everyone asks to be
> > > included and then notice when it was included fully with nothing
> > > missing and no amendmends.
> > > Maybe we could put a RELEASE_BLOCKER file in release branches in the future
> > > and everyone can list in it what needs to be done before the release
> > > and when something is done the person pushing would also remove that
> > > line from the file.
> >
> > Maybe you could stop bothering about things you are not good at and that
> > bore you.
> >
> > If releases need to be made, then let somebody step in for the role of
> > release manager. And if nobody steps in, let us not make releases.
> >
> > After all, WE do not need to make releases: it is the other projects who
> > need us to make releases.
> >
> > Regards,
>
> I think it should be more like, as release manager, he decides when to cut a
> branch and when to tag a release within that branch, and in either case
> giving a warning with some time in advance.
Thats what i did in the past pretty much and iam more than happy with that.
but this time things didnt work that well with the branch as there was some
stuff people really wanted in. So i tried to be a bit more cautious with
"just releasing". Also the channels waiting added delay at the start.
I didnt say it previously but i think waiting for a feature like the
channels API is a bad idea. If its ready, its ready if not i think we
shouldnt connect releases to it and make it more constraint for everyone.
> Saying "Anything else?" then waiting for people and constantly postponing
> tagging is not going to work. And it's not the first time this happens.
It didnt work very well here.
>
> Right now the branch is made and and the feature set frozen, and anything
> that could be backported can wait until 5.0.1. Cutting the branch is when
> interested parties should spoke and be hasty as that means a feature freeze.
> But right now, the release can and should be made whenever Michael wants to.
yes, you are correct, i agree, this whole thing here unneccesarily complicated
things compared to past releases
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-12 16:30 ` Michael Niedermayer
2022-01-12 16:36 ` Nicolas George
@ 2022-01-12 21:35 ` Soft Works
2022-01-13 4:02 ` Xiang, Haihao
1 sibling, 1 reply; 20+ messages in thread
From: Soft Works @ 2022-01-12 21:35 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> Niedermayer
> Sent: Wednesday, January 12, 2022 5:31 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] 5.0 blocking issues
>
> On Wed, Jan 12, 2022 at 07:37:03AM +0100, Lynne wrote:
> > 8 Jan 2022, 17:30 by michael@niedermayer.cc:
> >
> > > Hi all
> > >
> > > This is a simple go/no go call
> > > if you know of something that still should go into 5.0 please reply here
> > > with a list of what you are working on and a timelimit until when you
> > > will be done with it
> > >
> > > if you think everything is ready for the release, then too feel free to
> > > reply (assuming few others said ok yet) this is not supposed to become a
> > > 100 reply thread with oks, just maybe 2-3 people confirming that noone
> > > is aware of things missing.
> > >
> > > I intend to do the release within 2-3 days of all "no go" things being
> > > resolved or timeouting
> > >
> > > thx
> > >
> >
> > Both of elenril and mkver's patches got merged, isn't it
> > time to tag and make archives already?
>
> something is not working efficiently here
> There have been more replies here than from elenril and mkver
> also there have been over the ML multiple requests for backports
> to 5.0 today. (which may or may not be all unimportant)
> We do need a better way to detect when a branch is ready for release
> or master is ready to be branched.
> Iam really bad at keeping track of everything everyone asks to be
> included and then notice when it was included fully with nothing
> missing and no amendmends.
> Maybe we could put a RELEASE_BLOCKER file in release branches in the future
> and everyone can list in it what needs to be done before the release
> and when something is done the person pushing would also remove that
> line from the file.
>
> for 5.0 now, i guess this is a 2nd go/no go call here
> anything else that I should wait for ?
> if not i will make the release _probably_ in the next 2-3 days or so
> (if nothing interferes)
[PATCH v4] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11)
Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-15%2Fsoftworkz%2Fqsv_vpp_regression-v4
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/15
Patchwork: https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.15.v4.ffstaging.FFmpeg.1641538891098.ffmpegagent@gmail.com/
=> Has been merged in to master
[PATCH] avcodec/dvdsubdec: fix incorrect yellow appearance of dvd subtitles
Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-16%2Fsoftworkz%2Fpatch_dvdsubdec_fix-v1
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/16
Patchwork: https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.16.ffstaging.FFmpeg.1641262759164.ffmpegagent@gmail.com/
=> not merged yet
Thanks,
softworkz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-12 21:35 ` Soft Works
@ 2022-01-13 4:02 ` Xiang, Haihao
2022-01-13 11:34 ` James Almer
0 siblings, 1 reply; 20+ messages in thread
From: Xiang, Haihao @ 2022-01-13 4:02 UTC (permalink / raw)
To: ffmpeg-devel
On Wed, 2022-01-12 at 21:35 +0000, Soft Works wrote:
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> > Niedermayer
> > Sent: Wednesday, January 12, 2022 5:31 PM
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] 5.0 blocking issues
> >
> > On Wed, Jan 12, 2022 at 07:37:03AM +0100, Lynne wrote:
> > > 8 Jan 2022, 17:30 by michael@niedermayer.cc:
> > >
> > > > Hi all
> > > >
> > > > This is a simple go/no go call
> > > > if you know of something that still should go into 5.0 please reply here
> > > > with a list of what you are working on and a timelimit until when you
> > > > will be done with it
> > > >
> > > > if you think everything is ready for the release, then too feel free to
> > > > reply (assuming few others said ok yet) this is not supposed to become a
> > > > 100 reply thread with oks, just maybe 2-3 people confirming that noone
> > > > is aware of things missing.
> > > >
> > > > I intend to do the release within 2-3 days of all "no go" things being
> > > > resolved or timeouting
> > > >
> > > > thx
> > > >
> > >
> > > Both of elenril and mkver's patches got merged, isn't it
> > > time to tag and make archives already?
> >
> > something is not working efficiently here
> > There have been more replies here than from elenril and mkver
> > also there have been over the ML multiple requests for backports
> > to 5.0 today. (which may or may not be all unimportant)
> > We do need a better way to detect when a branch is ready for release
> > or master is ready to be branched.
> > Iam really bad at keeping track of everything everyone asks to be
> > included and then notice when it was included fully with nothing
> > missing and no amendmends.
> > Maybe we could put a RELEASE_BLOCKER file in release branches in the future
> > and everyone can list in it what needs to be done before the release
> > and when something is done the person pushing would also remove that
> > line from the file.
> >
> > for 5.0 now, i guess this is a 2nd go/no go call here
> > anything else that I should wait for ?
> > if not i will make the release _probably_ in the next 2-3 days or so
> > (if nothing interferes)
>
>
> [PATCH v4] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11)
>
> Published-As:
> https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-15%2Fsoftworkz%2Fqsv_vpp_regression-v4
>
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/15
> Patchwork:
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.15.v4.ffstaging.FFmpeg.1641538891098.ffmpegagent@gmail.com/
>
> => Has been merged in to master
>
It would be better to include this fix in 5.0 release. May I cherry-pick this
patch to the release branch ?
Thanks
Haihao
>
> [PATCH] avcodec/dvdsubdec: fix incorrect yellow appearance of dvd subtitles
>
> Published-As:
> https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-16%2Fsoftworkz%2Fpatch_dvdsubdec_fix-v1
>
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/16
> Patchwork:
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.16.ffstaging.FFmpeg.1641262759164.ffmpegagent@gmail.com/
>
> => not merged yet
>
>
> Thanks,
> softworkz
>
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [FFmpeg-devel] 5.0 blocking issues
2022-01-13 4:02 ` Xiang, Haihao
@ 2022-01-13 11:34 ` James Almer
0 siblings, 0 replies; 20+ messages in thread
From: James Almer @ 2022-01-13 11:34 UTC (permalink / raw)
To: ffmpeg-devel
On 1/13/2022 1:02 AM, Xiang, Haihao wrote:
> On Wed, 2022-01-12 at 21:35 +0000, Soft Works wrote:
>>> -----Original Message-----
>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
>>> Niedermayer
>>> Sent: Wednesday, January 12, 2022 5:31 PM
>>> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
>>> Subject: Re: [FFmpeg-devel] 5.0 blocking issues
>>>
>>> On Wed, Jan 12, 2022 at 07:37:03AM +0100, Lynne wrote:
>>>> 8 Jan 2022, 17:30 by michael@niedermayer.cc:
>>>>
>>>>> Hi all
>>>>>
>>>>> This is a simple go/no go call
>>>>> if you know of something that still should go into 5.0 please reply here
>>>>> with a list of what you are working on and a timelimit until when you
>>>>> will be done with it
>>>>>
>>>>> if you think everything is ready for the release, then too feel free to
>>>>> reply (assuming few others said ok yet) this is not supposed to become a
>>>>> 100 reply thread with oks, just maybe 2-3 people confirming that noone
>>>>> is aware of things missing.
>>>>>
>>>>> I intend to do the release within 2-3 days of all "no go" things being
>>>>> resolved or timeouting
>>>>>
>>>>> thx
>>>>>
>>>>
>>>> Both of elenril and mkver's patches got merged, isn't it
>>>> time to tag and make archives already?
>>>
>>> something is not working efficiently here
>>> There have been more replies here than from elenril and mkver
>>> also there have been over the ML multiple requests for backports
>>> to 5.0 today. (which may or may not be all unimportant)
>>> We do need a better way to detect when a branch is ready for release
>>> or master is ready to be branched.
>>> Iam really bad at keeping track of everything everyone asks to be
>>> included and then notice when it was included fully with nothing
>>> missing and no amendmends.
>>> Maybe we could put a RELEASE_BLOCKER file in release branches in the future
>>> and everyone can list in it what needs to be done before the release
>>> and when something is done the person pushing would also remove that
>>> line from the file.
>>>
>>> for 5.0 now, i guess this is a 2nd go/no go call here
>>> anything else that I should wait for ?
>>> if not i will make the release _probably_ in the next 2-3 days or so
>>> (if nothing interferes)
>>
>>
>> [PATCH v4] avfilter/vpp_qsv: fix regression on older api versions (e.g. 1.11)
>>
>> Published-As:
>> https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-15%2Fsoftworkz%2Fqsv_vpp_regression-v4
>>
>> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/15
>> Patchwork:
>> https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.15.v4.ffstaging.FFmpeg.1641538891098.ffmpegagent@gmail.com/
>>
>> => Has been merged in to master
>>
>
> It would be better to include this fix in 5.0 release. May I cherry-pick this
> patch to the release branch ?
It's a bug fix, not a feature addition or behavior change, so it matches
the criteria for backporting. Feel free to do it.
>
> Thanks
> Haihao
>
>
>>
>> [PATCH] avcodec/dvdsubdec: fix incorrect yellow appearance of dvd subtitles
>>
>> Published-As:
>> https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-16%2Fsoftworkz%2Fpatch_dvdsubdec_fix-v1
>>
>> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/16
>> Patchwork:
>> https://patchwork.ffmpeg.org/project/ffmpeg/patch/pull.16.ffstaging.FFmpeg.1641262759164.ffmpegagent@gmail.com/
>>
>> => not merged yet
>>
>>
>> Thanks,
>> softworkz
>>
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 20+ messages in thread