From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E6B1340C5F for ; Wed, 29 Dec 2021 11:47:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4CA9168AEB2; Wed, 29 Dec 2021 13:47:09 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A9CE268A868 for ; Wed, 29 Dec 2021 13:47:01 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 1BTBl0uK013710 ; Wed, 29 Dec 2021 12:47:00 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 074A6E62AD; Wed, 29 Dec 2021 12:46:59 +0100 (CET) Date: Wed, 29 Dec 2021 12:46:59 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <280498BE-226E-41E2-BE17-DE2D47EAFFC0@mail.de> <0768FA6E-731F-4214-8B90-A3F38764010F@mail.de> <20211210164657.GF2829255@pb2> <727CF2F6-C834-415A-B771-4F70661F8BE8@mail.de> <3E808BD2-808B-4C53-B1F7-B9DFFE2BF687@mail.de> MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 29 Dec 2021 12:47:00 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: thilo.borgmann@mail.de Content-Type: multipart/mixed; boundary="===============9180766672086781492==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============9180766672086781492== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LTSlrgrgF1BT1/J0" Content-Disposition: inline --LTSlrgrgF1BT1/J0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable "zhilizhao(=E8=B5=B5=E5=BF=97=E7=AB=8B)" (12021-12-29): > How about add a restriction like this: >=20 > if (format.endsWith(=E2=80=9C%S")) > enable the feature > else > warning message >=20 > It=E2=80=99s a useful feature, it shouldn't create unexpected results, but > doesn=E2=80=99t need to support every use case. I would not oppose it, but I find it inelegant, especially because it requires a different expansion function, localtime_ms instead of localtime. What about this: with the original function "localtime", if the format ends in "%3N", then append the millisecond. It can later be expanded to support %xN at any place in the format for any value of x. Regards, --=20 Nicolas George --LTSlrgrgF1BT1/J0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmHMSrEACgkQcZVLI8pN xgxJlA/+LvD/CpYtZvYfBt5hFhu76R5IbtA20n8N9CdEbIhdj+sk2m/NcCBfPYbN On3pjmaQE5bC73TNTV1qgLzuvkLvBQcHBKbmQHZuxFk61M3ehC9l3k5SwFnbtASC BvmSNEA9jzqgH/kt/E/+G2QTw5bkvQgGy0QZn/mD/xluhqu0h/6wA11D5sqskOP9 /Y7UpSNRtG/7zKpiSoDE7iL1MjgvsnJwfTpiYHTepR6gHQuTMNM//tHYn4Fydfnl TKVKWzVBDHB7YpHDrkvtICkP0C2yBf9Clu38lNuPIRPqLO1jp2VpfaWy35aKO4sj pYkZa+GDXW5W6xrFd605F2EPiAs7W6RfL0pUXJRExwvkL+EHyVUhyCqaUWPWHDK/ HcgRrHJKRqZP89wrOQqKe1iWN57TDahaqKwnFMjCDUQ9tuRhov+f+VYvr8ckV+Y8 vVH71cZ5MZW1ZXMK7w8RlX2OKFsgj1vATwwmJnPQlFzm2PlzjGy+Blma2IrjYCYn kpJeXJ21iUXsxPpE+anGOq4vV/GCJWcfkzwkM9XqPVFIEV7dHEjHEZO0BJgt+9tG imiKjhGIz5BxVxUBPUcGbMYkeHKrO+Mmyc0K7kNkjXQ4QQ6b7jNOnykpeWNBMcO8 LJt3MV7waF4M4hTff06nuOSs7wuboP7ydHgxRQgM87tAC1NFT1c= =XmLW -----END PGP SIGNATURE----- --LTSlrgrgF1BT1/J0-- --===============9180766672086781492== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============9180766672086781492==--