Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: thilo.borgmann@mail.de
Subject: Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision
Date: Wed, 29 Dec 2021 12:46:59 +0100
Message-ID: <YcxKswIRNQgs+7xQ@phare.normalesup.org> (raw)
In-Reply-To: <tencent_46299DE2E1E85AFE348D810A34053EB35609@qq.com>


[-- Attachment #1.1: Type: text/plain, Size: 690 bytes --]

"zhilizhao(赵志立)" (12021-12-29):
> How about add a restriction like this:
> 
> if (format.endsWith(“%S"))
>     enable the feature
> else
>     warning message
> 
> It’s a useful feature, it shouldn't create unexpected results, but
> doesn’t need to support every use case.

I would not oppose it, but I find it inelegant, especially because it
requires a different expansion function, localtime_ms instead of
localtime.

What about this: with the original function "localtime", if the format
ends in "%3N", then append the millisecond. It can later be expanded to
support %xN at any place in the format for any value of x.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2021-12-29 11:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <280498BE-226E-41E2-BE17-DE2D47EAFFC0@mail.de>
     [not found] ` <tencent_9187CFF05512A70F389C961C4D142031CD07@qq.com>
     [not found]   ` <0768FA6E-731F-4214-8B90-A3F38764010F@mail.de>
     [not found]     ` <20211210164657.GF2829255@pb2>
     [not found]       ` <727CF2F6-C834-415A-B771-4F70661F8BE8@mail.de>
     [not found]         ` <AM7PR03MB6660ED0E212D1CCB2134A4DD8F729@AM7PR03MB6660.eurprd03.prod.outlook.com>
     [not found]           ` <3E808BD2-808B-4C53-B1F7-B9DFFE2BF687@mail.de>
     [not found]             ` <YbZXwy3d8Z9rG/hD@phare.normalesup.org>
2021-12-29 10:47               ` "zhilizhao(赵志立)"
2021-12-29 11:46                 ` Nicolas George [this message]
2022-01-03 15:22                   ` Thilo Borgmann
2022-01-06 11:27                     ` Thilo Borgmann
2022-01-14 12:14                       ` Thilo Borgmann
2022-01-14 13:17                         ` "zhilizhao(赵志立)"
2022-01-14 17:40                           ` Thilo Borgmann
2022-01-14 18:02                             ` Zhao Zhili
2022-01-14 18:05                             ` Andreas Rheinhardt
2022-01-14 18:15                               ` Thilo Borgmann
2022-01-14 18:22                                 ` Andreas Rheinhardt
2022-01-14 17:57                         ` Nicolas George
2022-01-14 18:04                           ` Thilo Borgmann
2022-01-14 18:08                             ` Nicolas George
2022-01-14 18:20                               ` Thilo Borgmann
2022-01-16 11:06                                 ` Nicolas George
2022-01-18 12:52                                   ` Thilo Borgmann
2022-01-19  3:16                                     ` "zhilizhao(赵志立)"
2022-01-20 12:04                                       ` Thilo Borgmann
2022-01-20 14:58                                         ` Thilo Borgmann
2022-01-20 15:03                                           ` Andreas Rheinhardt
2022-01-20 15:32                                             ` Thilo Borgmann
2022-01-31 10:13                                               ` Thilo Borgmann
2022-01-31 13:08                                                 ` Nicolas George
2022-01-31 20:59                                                   ` Thilo Borgmann
2022-01-31 23:10                                                     ` Andreas Rheinhardt
2022-01-31 23:40                                                     ` Andreas Rheinhardt
2022-02-08  9:17                                                       ` Thilo Borgmann
2022-02-08  9:27                                                         ` Andreas Rheinhardt
2022-02-08 10:41                                                           ` Thilo Borgmann
2022-02-22 11:36                                                             ` Thilo Borgmann
2022-03-06 20:38                                                               ` Thilo Borgmann
2022-03-08 12:30                                                                 ` Thilo Borgmann
2022-01-14 13:10                       ` James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YcxKswIRNQgs+7xQ@phare.normalesup.org \
    --to=george@nsup.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=thilo.borgmann@mail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git