Re: [FFmpeg-devel] [PATCH 5/5] avformat/mvdec: Check bytes_per_sample

From: Peter Ross <pross@xvid.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 5/5] avformat/mvdec: Check bytes_per_sample
Date: Fri, 24 Dec 2021 10:07:58 +1100
Message-ID: <YcUBTrvW4QlpWMzQ@301de4447f55623bb5f04e9d71fc65fe> (raw)
In-Reply-To: <20211223211527.20408-5-michael@niedermayer.cc>

[-- Attachment #1.1: Type: text/plain, Size: 1037 bytes --]

On Thu, Dec 23, 2021 at 10:15:27PM +0100, Michael Niedermayer wrote:
> Fixes: division by zero
> Fixes: 42814/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-4787014237552640
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/mvdec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c
> index 1a5012e5076..390f6ba4de8 100644
> --- a/libavformat/mvdec.c
> +++ b/libavformat/mvdec.c
> @@ -366,6 +366,9 @@ static int mv_read_header(AVFormatContext *avctx)
>              avpriv_request_sample(avctx, "Audio compression (format %i)", v);
>          }
>  
> +        if (bytes_per_sample <= 0)
> +            return AVERROR_INVALIDDATA;
> +
>          if (set_channels(avctx, ast, avio_rb32(pb)) < 0)
>              return AVERROR_INVALIDDATA;

please apply.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".