Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Gerard Sole <g.sole.ca@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] libavformat: add side_data copy in concat demuxer
Date: Wed, 15 Dec 2021 20:05:00 +0100
Message-ID: <Ybo8XJ7KcoE9qRaK@phare.normalesup.org> (raw)
In-Reply-To: <20211215190031.14529-1-g.sole.ca@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1216 bytes --]

Gerard Sole (12021-12-15):
> Adds support for concat demuxer to copy the side data information
> from the input file to the resulting file. It will behave like the
> metadata copy, where the metadata of the first file is kept in the
> the output file.
> 
> Extract the current code that already performs the stream side_data
> copy into a separate method and reuse the method in the concat demuxer.
> 
> Signed-off-by: Gerard Sole <g.sole.ca@gmail.com>
> ---
>  libavformat/concatdec.c                             | 1 +
>  libavformat/internal.h                              | 9 +++++++++
>  libavformat/utils.c                                 | 9 +++++++++
>  tests/ref/fate/concat-demuxer-extended-lavf-mxf     | 2 +-
>  tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +-
>  tests/ref/fate/concat-demuxer-simple1-lavf-mxf      | 1 +
>  tests/ref/fate/concat-demuxer-simple1-lavf-mxf_d10  | 1 +
>  tests/ref/fate/concat-demuxer-simple2-lavf-ts       | 1 +
>  8 files changed, 24 insertions(+), 2 deletions(-)

Sorry. I was about to apply it but something else came up. This version
looks even better. I will try to find time in the next few days.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2021-12-15 19:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 19:00 Gerard Sole
2021-12-15 19:05 ` Nicolas George [this message]
2021-12-15 19:15 ` Andreas Rheinhardt
2021-12-15 23:16   ` Gerard Solé
2021-12-22 11:29 ` Nicolas George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ybo8XJ7KcoE9qRaK@phare.normalesup.org \
    --to=george@nsup.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=g.sole.ca@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git