Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Peter Ross <pross@xvid.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/mvdec: explicitly set duration
Date: Sun, 19 Dec 2021 14:16:04 +1100
Message-ID: <Yb6j9JWAF7+qEqBL@301de4447f55623bb5f04e9d71fc65fe> (raw)
In-Reply-To: <20211218204628.22664-2-jpstewart@personalprojects.net>


[-- Attachment #1.1: Type: text/plain, Size: 1019 bytes --]

On Sat, Dec 18, 2021 at 03:46:28PM -0500, John-Paul Stewart wrote:
> Resolves a warning that duration is being innaccurately estimated based
> on bitrate.
> 
> Signed-off-by: John-Paul Stewart <jpstewart@personalprojects.net>
> ---
>  libavformat/mvdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c
> index a5c5b205a6..1a5012e507 100644
> --- a/libavformat/mvdec.c
> +++ b/libavformat/mvdec.c
> @@ -319,7 +319,7 @@ static int mv_read_header(AVFormatContext *avctx)
>          avio_skip(pb, 4);
>          vst->codecpar->codec_type = AVMEDIA_TYPE_VIDEO;
>          vst->avg_frame_rate = fps;
> -        vst->nb_frames         = avio_rb32(pb);
> +        vst->duration = vst->nb_frames = avio_rb32(pb);
>          v = avio_rb32(pb);
>          switch (v) {
>          case 1:

both patches look good, and do not break tests.
i will apply in a couple of days.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2021-12-19  3:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-18 20:46 [FFmpeg-devel] [PATCH 1/2] avformat/mvdec: read frame rate from data stream John-Paul Stewart
2021-12-18 20:46 ` [FFmpeg-devel] [PATCH 2/2] avformat/mvdec: explicitly set duration John-Paul Stewart
2021-12-19  3:16   ` Peter Ross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yb6j9JWAF7+qEqBL@301de4447f55623bb5f04e9d71fc65fe \
    --to=pross@xvid.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git