From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1E64D4F9BD for ; Tue, 24 Jun 2025 03:09:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 32EBC68C1CB; Tue, 24 Jun 2025 06:09:36 +0300 (EEST) Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2095.outbound.protection.outlook.com [40.107.115.95]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5816568C1A0 for ; Tue, 24 Jun 2025 06:09:29 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PrenCp73NPL6LXkmtLVmXz/FQDuWW/2Syt/et7vtsVis7jjJ9TNaZW7y7qtPIqEvtNx6BHyCOXrc6j6xWxTQmvHDgSgf+cdkuhhYCLbgzmd/A6UjslzmKZEv7QMYxx1mZZpseNG/49ll78D3np0BwjTDHmzoK3u9P50ILUvfLf5kTHk/vA8GZ7S8rcb0uaxq71LoWTrYXhnJfItCsohXdt5wnrlUfbn0DLD7ZbZC+ID61VOcF0W3360MKagif8jUPexeD8MTGFP2qK2fin3061VnxZEguWZXxSAcVbWvsoToceA8sQmj3E9LP2Yx46b9umnQ7Dn3msqeFkqD3oyaRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nTqRNaEDghy+FYAgjPfprW3Z98zxq56oy+VQ18zLatQ=; b=uOtSIM6ZUp4mLPEQV/Lp9l8bX7bEwN5l0zKE5W4E3cVUcEEzkf6CyGEN6g6xfU1eACMJhblSy41+bppfaEBrMZ4TWFPLQ+PgY7l2LCdCU2EX87dzcGcfVEa9nqfKAjuY68ReclE84SdYvcDJ5vWsVqvhiTvArWQqSKHiGCqJhY1w7OhwLwWodw8m90TntN7W3AYrCp/7O3QQZ8zbUcvt2YiZQCimsTU4cr3jpV0pKromdurwc+8rzkgGnoeZCP+Usf6zxi1CQ5+qPARj0r+mXDJb2aWrj7Gy1AWh62Cyvc6oRN8ICws0MI/FjKOxq28oNNx0dk+gGXQGg2MxSmZYcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=netint.ca; dmarc=pass action=none header.from=netint.ca; dkim=pass header.d=netint.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netint.ca; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nTqRNaEDghy+FYAgjPfprW3Z98zxq56oy+VQ18zLatQ=; b=alFM5TGBJCUsXBKaKeXW5pgSVuxKOVJXCCKUWm7jd68RjuNIsxfq/aZm5L8Ypwe3/Xh9Ma5x2zP8ZXUtvCKHfnBObbVEnjpywXDjBmHWIoqOxg5hK/5DKqtQ4YhTX90uh7tk92oeKqAmLHe7pvSeqBZ/G5pjEWanG4V2+ScK5D0= Received: from YT2PR01MB4701.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:3c::6) by YQBPR0101MB9502.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:62::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.30; Tue, 24 Jun 2025 03:09:24 +0000 Received: from YT2PR01MB4701.CANPRD01.PROD.OUTLOOK.COM ([fe80::6697:95af:2af:a8bb]) by YT2PR01MB4701.CANPRD01.PROD.OUTLOOK.COM ([fe80::6697:95af:2af:a8bb%6]) with mapi id 15.20.8857.026; Tue, 24 Jun 2025 03:09:24 +0000 From: Steven Zhou To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] fftools/ffmpeg_filter: at EOF, unref frame used for FPS conversion logic Thread-Index: Advkr4nORQhK0ZsgStaWpPMl4mtmBw== Date: Tue, 24 Jun 2025 03:09:23 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=netint.ca; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT2PR01MB4701:EE_|YQBPR0101MB9502:EE_ x-ms-office365-filtering-correlation-id: d3c94bcc-24fc-4b93-11b1-08ddb2cc8580 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?7zcP6D15zJjGglIAyOVCEK8m4oi/08Ha18Nh37PHlASE2nmUN0mLUDywC4/Y?= =?us-ascii?Q?FZVfXntmyI0lzE9YpiS8ZI6EPbbEjnvTVP7btuu19GmCcfkwzYqeQZdt7ZW1?= =?us-ascii?Q?GAg1LsYZ0Hegu+nDJf6AWbUWIvK6dRLeDR5gm0vQ5zqjAJRuR5D4/zYTeZRa?= =?us-ascii?Q?C7DK4Nxv85baldjS1hHyCMb9LHM2wZbzX5uLQfAeNo7KB/hkXjvn0AEj92eJ?= =?us-ascii?Q?EUG0xsNLdG35l/4WyLBcOvyZ5r0/ngpof03JpzULGypn64COEIwuS88b+XWV?= =?us-ascii?Q?ZKd9IHyUpniDr2Gp52OcdSaCb6bbwgxhCtOZNlTNVKme3cuvxEZh/WJ+171U?= =?us-ascii?Q?aSxRUOAhugK2qPapzwOEqZ4EEjZl2w2CWR0s+pOhN1QRATeGqevVB+N9RWQJ?= =?us-ascii?Q?Ror5tWWUplrp3lTRe3ZoUEAB18TBZiYRGvcypwywIO6l4ey7xc7JLBmepuLQ?= =?us-ascii?Q?Xd1OOoK+GzZ5LajZLsNeJYLSWvbjCQxYqJManvUPXm6TRcj4j5ddsr8oNOS4?= =?us-ascii?Q?1yVR8NsbSnS6J6Lfx7SgEkzk6qV5sUm5SOMFtTYpmBsCbKi9M/g9ll0KgNQN?= =?us-ascii?Q?pT8HvVzFnsfV4QkZvfF4GZVhDnebdErnZUp5zLuwgn8pJx8HlTDBv9+UcXVd?= =?us-ascii?Q?wdFiryrayDOZz8rT4EPqrQfw1CPaOFMhygZPqdhRqkXL15g0smpR+5qI9R0R?= =?us-ascii?Q?UMM6dDShXV23eJCrxAGr0BInZt6rs0b/+kW328B9MkbCtnFkSsO/X3fON2Ud?= =?us-ascii?Q?XFYt5CSj/TXzwthj994Vrl6FOl2r8vDtggqMcssEiH+H0iOghEewF8rz7JUa?= =?us-ascii?Q?C2g4AWX0qowwRqU1OuDpSAg7ps6oyMQjbSH3GJq1II8DSjgi8/LFsMHhdnqD?= =?us-ascii?Q?ZB3ucIQjPb0wFnL07dVi8QXfstL8YhORotdlRS6fi0ZFbnh4u8OTNVr0t1K9?= =?us-ascii?Q?9z84hgwjRL1502GfQfihNz74owiI1nndPOFq/9dirG6pq2i2g/j8R2PeIIWt?= =?us-ascii?Q?SHcUJpNM/5TsdRFseDjpEXNR7aNIlwpN2AjORMMTjgVbazrvcKU7s21IPLqC?= =?us-ascii?Q?KNLTyBFWNpuJfPbwf4WVbsznBgS5VVe6eq7ScRZymYtWoiYZOaSZmioWPPGv?= =?us-ascii?Q?EqAM72nuEUvN4Ce0XnynmreNbCSo83UPEUZ0hVskbGwgGqYd+pA4kKhQJCPy?= =?us-ascii?Q?LIiA5EpHSFqM4AlXDmapZIXVGFXh/8ba9aueCJOhRz3pkFalP1XX/HFhdgwT?= =?us-ascii?Q?K9vdQFmqAlxd77kYVFRnJB4W8UZuOogJVHmHZsBUoF1sEB6uk5wTkKEua/wk?= =?us-ascii?Q?Q5QqLOyERzyqBej4UvRkjWsuztB3ucRMJm/Fy5BbsMHORnVviYnZ5vdmg+9m?= =?us-ascii?Q?MzF522dx2DG+Mjy+kojFHIpGJRih9m9HNa/nF6izOE8FlMQWP9ltaJhFRQK3?= =?us-ascii?Q?Ww4aPkTEb2D/lgTmEXjJt42jVXNlTlSYrKwn5Va2LebIyIh8AUV6XQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT2PR01MB4701.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6J2RdyxifnStd4Zl5BN0rT1e9UCXIGk7/gMmgVJ15ZKk8U4SpGpkIeK3WuO+?= =?us-ascii?Q?8EIqil5Q49/d4d5jxQ+z4UIP9seDpMnALGaRII7Z3xNKvodCb0hBm5pOZ6W8?= =?us-ascii?Q?8g6vBhvAjHdI8L14RVJBA1i4u9wGYaID5tdQNfn0zWMSS1JV+bVjXm7TWy1J?= =?us-ascii?Q?NV15/aEjxwTS+Gef/NaLhagJz8U1xNk/rYDHTxbad7OQEoZlgdfD7ROwZksI?= =?us-ascii?Q?C3Gtvs1YGMISq3oZN6MBXVyLnk3B1LDKC/WSlu20jJ4Vh7IUNZQAiNNe3So0?= =?us-ascii?Q?EbgoMDaMQtX0lkixOpIQatPY2+RtKkmVusXtU1yeKFXx+flSUSKBLVLtOUzs?= =?us-ascii?Q?iv7dIZdFsPVReyaAQIKk77ktmY0Dsv66mI37NOfLxyg4Fq6Mw6PvZPDJ+dNe?= =?us-ascii?Q?kV6X/Lah013RkkYz102zOrqVaGZzC2HZm+24xIrSb/NoBUeGwKsrxx3jn3J6?= =?us-ascii?Q?Nkkuu1laYzurawAfqykFqgtEzzGs0wHtguE2jEtC46dpHj/w+J2T584LaAHQ?= =?us-ascii?Q?fYECgvIrEDw14InbUng25cKNBTnX2UHu7nEPdUZPfQ1OR5guxJPtH8ILjaOl?= =?us-ascii?Q?mPlZc+++dbdfm06Eq//rvrPni8ugs8Pe4GG2UwpORBISBr/bF/LgP+90cqjZ?= =?us-ascii?Q?yLRB1bebHGfOaxzBY4S+rcd2cfeIbslXKcOwfmvnt73PznLugYYoAJU/abNM?= =?us-ascii?Q?D104plz+DgNTM0PC3q6FxnMKzIMKTdwhgE+Ih0/UpYqksY0kIs6RSeKwPB8o?= =?us-ascii?Q?CFmjlwWc32rYo+ytWuXfGkq/P9DZGbhBkgDHrqjKr/6E+WwgHXCdrAuOx8Cx?= =?us-ascii?Q?bC+w9q6jwi4mACisTqCQYCwYWniyAhB1MM0qv215Z5h7tCfU3TPiXZWggfLQ?= =?us-ascii?Q?gHHU2BTFZwC0X4Fd7ZEOkh29D3kHCLpQsP8ZiC4LqiDC2wtoOKBLYMRnEM0W?= =?us-ascii?Q?ROK3Y20ckyiKK8tMHceOIEmmxOJkWbmCHaOw5hJm/T9rrv/+E8wGJFOocP4F?= =?us-ascii?Q?rhAdFm1TWCfDGwSnvsK3baA3Q9yT4hYXVRShzENdERAbrW2+ca790Xora93S?= =?us-ascii?Q?xmFA1rqHJmIjtCYL9RXR3qlHKL15Vy9k9H73U8v7Po2DTEXYcYqA8AI/OYR5?= =?us-ascii?Q?Xkm1Kmq9hzbLtuUmifHij70Ga/PgUsSufPhmu+DQtPkJ8RNusxFJEHapmUkZ?= =?us-ascii?Q?C0S+/OiudnYgs+VmMqgIBvS+szuYhI/7ELtGeTfEgtq7QuBKC2QbfyF1X9dJ?= =?us-ascii?Q?i7zBVCos9lSNpvTkQzicCllHR2rF5VUDeTRzaVBqPfsFr0qrTiVWP1G2YZDW?= =?us-ascii?Q?JH6rT7DPPvqLfd6nrmEeMhgLn7oSBuaFknMUnlVEbu2XJW8eEzsjJC8HnUva?= =?us-ascii?Q?BilQOyhrVZIdf9Th0mdo6UydhGdAva5RZX4VQGxViXBKvwnPV5ZwO1swkiMA?= =?us-ascii?Q?IOiN/OJmz6L3GgJvKbmY9O8qXt3c1tNvN1rEZo+qWtKtEIB1A/kSO7YiRDXv?= =?us-ascii?Q?Y3OVNaUyCt8iUrfplw6I3OPrYGGp8AMYZPiXtg3wLM90j8DuLFZL+7sRzMhi?= =?us-ascii?Q?FQQAPPgspAGWt4NpE9GSFVXRDYYzRZnBTTMZxhFJ?= MIME-Version: 1.0 X-OriginatorOrg: netint.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB4701.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: d3c94bcc-24fc-4b93-11b1-08ddb2cc8580 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2025 03:09:23.9060 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 76291bb4-3d04-48ef-9eb8-3e33475af3cb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DIcl+07hcpwD1ABZNFunye0KIO0Q22suDMhsFTlMzyrqnJUKz8E9gQO//6eyc4QGL7WGNzryF3k5cmQD/gQXXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB9502 Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: at EOF, unref frame used for FPS conversion logic X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: fftools/ffmpeg_filter: at EOF, unref frame used for FPS conversion logic Ever since commit 64f3feb added `avcodec_free_context(&enc->enc_ctx);` to `enc_free()` the encoder context is closed before filtergraph output context. The filtergraph output context holds a reference to last AVFrame to pass through it for FPS conversion purposes. This is problematic for HWFrameContexts which may rely on encoder context to free HW AVFrames. This change unrefs the AVFrame ref held by filtergraph output context during processing of EOF frame. Signed-off-by: Steven Zhou --- fftools/ffmpeg_filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index a0dc4c745e..cf2d016b2d 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -2560,8 +2560,10 @@ static int fg_output_frame(OutputFilterPriv *ofp, FilterGraphThread *fgt, av_frame_move_ref(frame_prev, frame); } - if (!frame) + if (!frame) { + av_frame_unref(frame_prev); return close_output(ofp, fgt); + } return 0; } -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".