From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 372484551A for ; Tue, 31 Jan 2023 16:13:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EB60A68BE28; Tue, 31 Jan 2023 18:13:33 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D92768BDE7; Tue, 31 Jan 2023 18:13:22 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 30VGDLKW006116 ; Tue, 31 Jan 2023 17:13:21 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 24CA9EB5BB; Tue, 31 Jan 2023 17:13:21 +0100 (CET) Date: Tue, 31 Jan 2023 17:13:21 +0100 From: Nicolas George To: FFmpeg development discussions and patches , tc@ffmpeg.org Message-ID: References: <20230130122937.12258-1-anton@khirnov.net> <167517302897.4503.15130184316413800795@lain.khirnov.net> <167517470800.4503.4882536660599256492@lain.khirnov.net> <167517869808.4503.13103529212008047943@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <167517869808.4503.13103529212008047943@lain.khirnov.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Tue, 31 Jan 2023 17:13:21 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] lavfi: get rid of FF_INTERNAL_FIELDS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0112960192289830519==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0112960192289830519== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Z1/YULOe0QHVJ/2R" Content-Disposition: inline --Z1/YULOe0QHVJ/2R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Anton Khirnov (12023-01-31): > I still see no objective facts supporting your claim of exclusive > maintainership over the entirety of lavfi generic code and public API. The fact is very simple: I am the only one who understand how this code works. > So to avoid any further pointless bickering, I'm hereby asking the TC to > resolve this. Just so we are clear: you are a party in this, you can therefore not be a judge. > To summarize my view, this patch is an improvement because: > * it prevents filterlink internals from being visible in a > public header, where they have no business being > * it is a step towards hiding more of lavfi internals from public > headers > * the same pattern is already and ever more widely used in the other > libraries and ffmpeg CLI > * it is supported by Andreas (who submitted a more general analogue of > this patch over a year ago) and Paul > * I am not aware of anyone other than Nicolas being against it It is a worsening because: * It requires the developers to remember which field is public and which field is private, which is not something relevant here (is is relevant elsewhere). Of course, if you think about it two seconds, you realize it affects the person who knows the code very well and used/wants to work on it intensively more than the developers who move from one part of the code to another and have to re-learn everything. But thinking two seconds how your changes affects other people does not seem like your forte either. Therefore, I add this point: * If this change is applied, FFmpeg needs to find somebody else to maintain the core of libavfilter. (And I predict you will not.) --=20 Nicolas George --Z1/YULOe0QHVJ/2R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmPZPh8ACgkQcZVLI8pN xgyYwBAAl+/1XwY5Lbw+uX/1qps5t38KNo4VswVEkpB6jRIwIGVSgjdQM46L5Oy5 HjOUoAIY3Whtl2MB4Tj/iFlIfZdxhOtm+7W3or3iCARG0+e0rNR4Wm3psHDyqsX2 /gAgCXAPZn6omZPJOqniJySEo/gA+9C99gDl+TfJhZ9r4OgLbuST65Hli+WDWVco V6FGGTIkDyrJAyKfX4/9JQrPUP5D6/iY4fDvhf+A/UAsvxZ7FI7/syzM6qF3Uvfl BQk6oNUhrePFAB4It5Pfephyn+7LOQdJs9kIgr6tDuT1s7ZxiRFBQJ+H8gU/YgEi 7hrsunHjMbdN2ohNM6j+wdmxh/aQkvA8H3XOLP/f6tkaY5qLsqW2QPoRhtbDMYAo WtnFoRgraxnUGRfk3970Fmi37s0ICLgLsi6Odv1Z2qNNCX4+aMj8R4HQ9Ps+J3MR YY9s+6aPZffHU7+rQ1nukN/iPkddpoe49BnW5lAm8X1NqwEXok3IlAQs6boJC3xQ uuXvXz3PWikmX0/bYDcRglf9g0k9+spuA2UgC6x6yK2QD9UXKGXQys7Yi4MLV9WX qwWctNw17haIl5ACJJIgWRdspu0wT05dHLNj4adDCJKgorHFZE1K5lZwN2Igz2VK iBcKQn+aXU9bdDOX0I/wBVSN4DKETpNgma7FtJY69TEx2ZiynVM= =TNCR -----END PGP SIGNATURE----- --Z1/YULOe0QHVJ/2R-- --===============0112960192289830519== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0112960192289830519==--