From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6BC96453A0 for ; Fri, 27 Jan 2023 14:47:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 12A2E68BE1A; Fri, 27 Jan 2023 16:47:27 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44F6868A4DB for ; Fri, 27 Jan 2023 16:47:20 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 30RElJvR030795 for ; Fri, 27 Jan 2023 15:47:19 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 6FCC1EB5BB; Fri, 27 Jan 2023 15:47:19 +0100 (CET) Date: Fri, 27 Jan 2023 15:47:19 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20230127131639.4928-1-anton@khirnov.net> <20230127131639.4928-2-anton@khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127131639.4928-2-anton@khirnov.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Fri, 27 Jan 2023 15:47:19 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH 2/4] lavfi/framesync: reorder functions to avoid a forward declaration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov (12023-01-27): > --- > libavfilter/framesync.c | 144 ++++++++++++++++++++-------------------- > 1 file changed, 71 insertions(+), 73 deletions(-) Getting rid of the forward declaration would be a good idea. But the order you have put the functions is completely illogical. For example you separated ff_framesync_preinit() and ff_framesync_init() with functions that have nothing to do with initialization. Moving framesync_advance() closer to its call point would probably be a much better idea. So: not like this. -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".