From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6EE1A44136 for ; Fri, 27 Jan 2023 00:00:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C44D668BD96; Fri, 27 Jan 2023 02:00:06 +0200 (EET) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 06F6868A767 for ; Fri, 27 Jan 2023 01:59:59 +0200 (EET) Received: from 4eb231a0d1b36cedda43a2a005befe4d ([1.152.221.23]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 30QNxhXX003375 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Thu, 26 Jan 2023 23:59:50 GMT Date: Fri, 27 Jan 2023 10:59:38 +1100 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20230122000222.18719-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: <20230122000222.18719-1-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/utils: use 32pixel alignment for bink X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4212209299449687666==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4212209299449687666== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/zflZU6cfnw8n3jE" Content-Disposition: inline --/zflZU6cfnw8n3jE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 22, 2023 at 01:02:21AM +0100, Michael Niedermayer wrote: > bink supports 16x16 blocks in chroma planes thus we need to allocate enou= gh. > Fixes: out of array access > Fixes: 55026/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzze= r-6013915371012096 >=20 > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/t= ree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index 2b63a498b9..87634e3711 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils.c > @@ -243,6 +243,8 @@ void avcodec_align_dimensions2(AVCodecContext *s, int= *width, int *height, > case AV_PIX_FMT_GBRAP16BE: > w_align =3D 16; //FIXME assume 16 pixel per macroblock > h_align =3D 16 * 2; // interlaced needs 2 macroblocks height > + if (s->codec_id =3D=3D AV_CODEC_ID_BINKVIDEO) > + w_align =3D 16*2; > break; > case AV_PIX_FMT_YUV411P: > case AV_PIX_FMT_YUVJ411P: please apply. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --/zflZU6cfnw8n3jE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCY9MT3gAKCRBnYHnFrEDd awLTAJoDxMMIWMfUN9sLcy9A6mxuBe7pGACfXQf0lYuhH93C5pwfUm8F6rnrUXs= =HImy -----END PGP SIGNATURE----- --/zflZU6cfnw8n3jE-- --===============4212209299449687666== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4212209299449687666==--