From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 244F244D35 for ; Fri, 20 Jan 2023 20:47:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 834A768BD25; Fri, 20 Jan 2023 22:47:26 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF30668B7FA for ; Fri, 20 Jan 2023 22:47:18 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 30KKlGYf012319 for ; Fri, 20 Jan 2023 21:47:16 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 5E8DEEB5BC; Fri, 20 Jan 2023 21:47:16 +0100 (CET) Date: Fri, 20 Jan 2023 21:47:16 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20230120193132.21597-1-anton@khirnov.net> <20230120193132.21597-4-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230120193132.21597-4-anton@khirnov.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Fri, 20 Jan 2023 21:47:16 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7075745139459942519==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7075745139459942519== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M2Nlvb98Uirhb/Rj" Content-Disposition: inline --M2Nlvb98Uirhb/Rj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Anton Khirnov (12023-01-20): > --- > libavfilter/graphparser.c | 537 +++++++++----------------------------- > 1 file changed, 126 insertions(+), 411 deletions(-) I notice you removed the "RFC" from the subject line, but I probably have comments. I need some time, my time is very limited these days. By the way, I am baffled that you would write a 30k+ patch on code you do not maintain and do not know well without consulting the maintainer who knows it. Regards, --=20 Nicolas George --M2Nlvb98Uirhb/Rj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmPK/dIACgkQcZVLI8pN xgyVcBAAkxu/0KF1+/H65vEBv0mFsnvcq/V0oeF/Y/5iDf1x8BMW4iI7mY33WMvn fUcrTNv54IMpd65nKZH2HltyD/BDfWpYKWIM80E5W55JKu8rkDwSxhhGNwiDVXmI Mv+VLTTm9st5mDoXg5nhrhhQxQtNffNjW/Y1n9ryXDw+exCthv+/dBvHnfsAZ5HK 4VJl6ZIOrO/Vbm0JVQPptIewitASceHTU20X2j9f/SahK+rZO6hyiUGiqlLMyatg +PVW+a7vx6OR0RztngBf6Di5NUhkaGv7oTNUtyuAhCpFWyUoyCIG+kthtk1mOrzq Ul46FV2TCiFaPBzFtj6+W7xFYRvTdZ+3IqDhPhTI62yihi5P81inHV0b2yLAcUgZ zBF1lzGdsQJUw3aABtv01jQLfjoUU32DY9W6TZeECaGPfERDS3gYrykKdLntUx+t 4+xpLyqUrQRHDu1PTnP84Fd3lkiTetLDk/Nmd8s/jZLuwTqzpZZAlGbsBFX85cwY L1n6YBpUG7mUjrjpKyAIYuO6quXOBu/4/xUbq/qf2Z5C3onQbHjpmsjDIw+Ishb2 XE3erINw8sLd3A2iooNywAYti1R5yeVY6uOFqsRaRC2j7UsQKeKy7ZEugUxRE0Mm uZRJznyh3RIodw8u0db7M47a4FL6CAjZY9rOpFAoTfmsIJdhQxo= =QEFr -----END PGP SIGNATURE----- --M2Nlvb98Uirhb/Rj-- --===============7075745139459942519== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7075745139459942519==--