From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8224044F18 for ; Mon, 9 Jan 2023 09:13:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E109668BC70; Mon, 9 Jan 2023 11:13:02 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ADD1968BBC9 for ; Mon, 9 Jan 2023 11:12:56 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 3099CtlG025446 ; Mon, 9 Jan 2023 10:12:55 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 4AA65EB5BB; Mon, 9 Jan 2023 10:12:55 +0100 (CET) Date: Mon, 9 Jan 2023 10:12:55 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20230108150622.15075-1-stanislav.ionascu@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230108150622.15075-1-stanislav.ionascu@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Mon, 09 Jan 2023 10:12:55 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/dvd: new dvd:// protocol for reading dvd folder/images X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Stanislav Ionascu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Stanislav Ionascu (12023-01-08): > dvd:// protocol uses libdvdread for opening folders and/or disc-images, > it then either identifies the longest title-set, or uses the title-set > parameter. > > After opening the dvd, it will read and output all VOBs, in sequence > defined by the program-chain. Thanks for the patch. The reason there was no DVD support in ffmpeg until now is that it is not as straightforward as it seems. Your patch is missing documentation, including documentation about its limitations. Please clarify various points: - VOBs contain not only the movie but also menu data: will it be mixed along with the movie or skipped? - Are the timestamps monotonous over a whole title? - Does ffmpeg correctly detect all the subtitles streams? - Does ffmpeg correctly detect the language of audio and subtitles streams? - Are chapters detected? Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".