From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5074A44055 for ; Sat, 24 Dec 2022 09:00:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE02F68BBCD; Sat, 24 Dec 2022 11:00:03 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4FD8568A6B5 for ; Sat, 24 Dec 2022 10:59:57 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 2BO8xuD7029218 ; Sat, 24 Dec 2022 09:59:56 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 3CBB9EB5BC; Sat, 24 Dec 2022 09:59:56 +0100 (CET) Date: Sat, 24 Dec 2022 09:59:56 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <7407e74b181e4e00a7b7104fb63cf56a@huawei.com> <8870f5f386ee4042a8aa0303ace8c51f@huawei.com> MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sat, 24 Dec 2022 09:59:56 +0100 (CET) Subject: Re: [FFmpeg-devel] =?utf-8?b?562U5aSNOiAg562U5aSNOiAgW1BBVENIXSBm?= =?utf-8?q?ftools/ffmpeg=5Fffplay=5Fffprobe=5Fcmdutils=3A_add_-mask=5Furl_?= =?utf-8?q?to_replace_the_protocol_address_in_the_command_with_the_asteris?= =?utf-8?b?ayAoKik=?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "wangqinghua \(I\)" Content-Type: multipart/mixed; boundary="===============7093365040806003950==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7093365040806003950== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0j7Lzh/ylxJxd/lM" Content-Disposition: inline --0j7Lzh/ylxJxd/lM Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Wujian(Chin) (12022-12-24): > This code simplicity does not affect the readability and > maintainability of the program You are not the one who maintain them, that is not your judgement. > The mask effect is like this=EF=BC=9Affmpeg -mask_url -i rtsp://tyyy.com = --> ffmpeg -mask_url -i *************** I know, it was obvious from the start. > > this way you miss credentials passed through options.=20 > I still don't understand. Can you go into more detail? Look up cryptokey in the documentation for example. > >> >sizeof(*argv2) > Sorry, I didn't get it. This is elementary C and a staple of FFmpeg's coding style. > I understand that mask_url needs to be placed first, And that is an unacceptable misfeature. > because the FFmpeg process of the ps -ef command is viewed as argv, That is nonsense. > Therefore, you need to copy argv to argv_copy immediately, mask the URL i= n the argv,=20 > and then argv_copy is a command without mask_url for the following progra= ms. The few milliseconds of the normal options parsing will not make a difference. > I don't understand the difference between the normal option and the mask_= url in use? Your version is a special case that needs to be maintained. That is only acceptable with a very good reason, and you have not provided one. > Looking forward to your reply, thank you. Let me be clear: this here is a review of your code, not a tutorial on becoming a better developer, and even less "what an excellent idea, let us do the work for you". --=20 Nicolas George --0j7Lzh/ylxJxd/lM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmOmv4kACgkQcZVLI8pN xgxzvw//bX0wouiOksgH2ohvLe3ewHq3gH0MY4MaGCVxIhptWjJN2BQOVxSw/FxL w0h9V5OudNGoFc6W4nnFPtMP7e8RAmMz5ebe6TYGZXM+dTutZd8+QUJWBBRVwhlD +0kg8F73pVTNtjbb82+ZL9QslD5sh5HsUBuobJWSOTZbjJ8dgvjvpLnWlgWL1wix SAHxehv42NVpxK6LR4AhNspYtssslJWzToUNNfkjDrgruGp8Du6uuZePX8JokvB/ FMfumrQOUQVOZU4namhKmDrstNqVcSHal9suLWXfdvioFy5Xco35379AR4FIFSR7 3JLUaTM6PnWC9IBJ5m6YNv/oG5cELEd1+0oAc+OuNdi728ejfemiR6uYYfPCejvt CnPC6vjoi3kaUAMXKJLe2LhQURWYKe3kmfMDdoYPuXJWkfJnDfbyUK7Jya2d+zgH vjsHPxxDC0PGx7rsreBZSfaTxhDUeuOmYT6UMclYATJHjyOxCOVD1vOf8ab28xag 3itGgq56kpWeT9L8fNHFpIcoU97RrudiuQdi/l/IkD+8qe6nA9+D0mEwIejIjTkJ +mXLhi/SmiscXtZ/D5f5wbQIyn9KVrQguoVo8zajSdNXC5vA+PFYlmDsh0NGB+UY dp9lvEuNX1e7OlJHRSPzntIW/8xMIOrXkaWNzRvjhh0nHIFqY64= =mXTl -----END PGP SIGNATURE----- --0j7Lzh/ylxJxd/lM-- --===============7093365040806003950== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7093365040806003950==--