From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6C90A44D58 for ; Thu, 22 Dec 2022 19:32:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2FC7568BA2B; Thu, 22 Dec 2022 21:32:37 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 17D2468058E for ; Thu, 22 Dec 2022 21:32:31 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 2BMJWUYi028439 for ; Thu, 22 Dec 2022 20:32:30 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 6B7DDEB5BC; Thu, 22 Dec 2022 20:32:30 +0100 (CET) Date: Thu, 22 Dec 2022 20:32:30 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <267cc4be14117eb7b02371844ddff14485c60110.camel@voila.events> MIME-Version: 1.0 In-Reply-To: <267cc4be14117eb7b02371844ddff14485c60110.camel@voila.events> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Thu, 22 Dec 2022 20:32:30 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtpproto: add support for RTP/UDP socket reuse X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4867639411014280856==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4867639411014280856== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DH38hXY8HnIdpNuQ" Content-Disposition: inline --DH38hXY8HnIdpNuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Camille Oudot (12022-12-22): > This patch introduces a "reuse" option over the RTP protocol. It simply > passes the value to the underlying UDP protocol's "reuse" option. >=20 > Some RTP peers expect multiple streams to come from the same IP/port, e.g. > when RTP BUNDLE is involved (different streams sent from/to the same > srcIP/srcPort/dspIp/dspPort tuple), or when rtcp-mux is involved (RTP and > RTCP packets are muxed together). It is not your fault, but the name of the option is misleading: it does not reuse any sockets, it allows to reuse an *address* and maps to the SO_REUSEADDR socket option. The misleading part is already in udp.c, but I think we should avoid letting it proliferate. Also, instead of passing this particular option, I think it would be better to make the UDP context a child context of the RTP context, so that options are applied recursively automatically. Regards, --=20 Nicolas George --DH38hXY8HnIdpNuQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmOksMwACgkQcZVLI8pN xgwtJQ//c9k3hQoHLyUxYST5ommi8qeynZOFTlBTEw5lq2WtCeRX+ZzE1eiaoJGs 43JvdJPDXDkQfRJUxeLIEI6MyQ/u1ArgTg0GrE7OLl+uubBVILJz/XUOZEbp8KqO HdPffqXyLZn29Qg4FM4A7IwXGTA/PR3/icKN7AinObQ9sk4PSHxO4+Cad2jXBsmy 3tjq53naUjnoERW47Z0S5+uL6AWaajQ41kOvIuDvE/MgH030NEnUjJKB+pGw3cHx jBSzFKeYybk4pw9W6IDFroKu03ljkJK9Zxbo0PV2JwQYaLLEFZoe3334DULTpRhr FN7twvjPj1lF13NNT/PDIBY+r2JOF8qZ8oqZNBhuq4N13R2NNRE9CLVsr//iKoFp nvFmlMrdJpAttPJ78qCaPwuokoU6pKF9t49BPtcCMgx0i902LJlLf//NpAsdqpXw MBU3jsbevusbMYVUXBrpXJZ+6KB1Yf5zcpoOOKuWmT9aOpw1m9/Lkh6u9UK2y6E3 +w5x2dLFpuL0U6nUUXll9o5uYZUz5ntzCDTU5WeVgZYNYQNOyV4Tdk+CFX6Q/T3e rYuGF+3CIVfhd+gNEHmMzL0VNmWvMW/C/OzCBCSsiGPhgiEr51AefJU7MK1Ar96g uzyAJm5QHncnd43jHgY9zw64c2ItF4orIzV76wEG2Whd3LS8Kn4= =X8mN -----END PGP SIGNATURE----- --DH38hXY8HnIdpNuQ-- --===============4867639411014280856== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4867639411014280856==--