From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 443EE446B3 for ; Thu, 22 Dec 2022 19:28:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BAE5A68BA6B; Thu, 22 Dec 2022 21:28:16 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1934D68058E for ; Thu, 22 Dec 2022 21:28:10 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 2BMJS9RR027772 ; Thu, 22 Dec 2022 20:28:09 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 52155EB5BC; Thu, 22 Dec 2022 20:28:09 +0100 (CET) Date: Thu, 22 Dec 2022 20:28:09 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <2f52afe919284d9a872738dd68ab886f@huawei.com> MIME-Version: 1.0 In-Reply-To: <2f52afe919284d9a872738dd68ab886f@huawei.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Thu, 22 Dec 2022 20:28:09 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "wangqinghua \(I\)" Content-Type: multipart/mixed; boundary="===============6754220400039358980==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6754220400039358980== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z1xXoSzs7GU4qyqM" Content-Disposition: inline --z1xXoSzs7GU4qyqM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Wujian(Chin) (12022-12-21): > I have modified the issues again. Please review it again. Thank you. >=20 > If the protocol address contains the user name and password, the ps -ef > command exposes plaintext. The -mask_url parameter option is added to > replace the protocol address in the command line with the asterisk (*). > Because other users can run the ps -ef command to view sensitive > information such as the user name and password in the protocol address, > which is insecure. >=20 > Signed-off-by: wujian_nanjing > --- > doc/fftools-common-opts.texi | 11 +++++++ > fftools/cmdutils.c | 75 ++++++++++++++++++++++++++++++++++++++= ++++-- > fftools/cmdutils.h | 25 +++++++++++++++ > fftools/ffmpeg.c | 10 +++--- > fftools/ffplay.c | 9 ++++-- > fftools/ffprobe.c | 10 +++--- > 6 files changed, 126 insertions(+), 14 deletions(-) This new patch still has issues not addressed since the first review. Regards, --=20 Nicolas George --z1xXoSzs7GU4qyqM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmOkr8cACgkQcZVLI8pN xgzp4xAAqQPXrItDEuhcvi49wIQjuXkMPV8yLqON+LVqGkoFTeY5IuUJQqgtNUNW Rx3WoBU5k66r455yk8B8YtJwPWNViDetfrUczsdzB3gVpi4joWf1nFiZtcohhIak nToxTnLuJc6m4w8ggZusEu+pVoFqXlKmY/Zsd37hUeZSQzIduSnSWqQUIEfrOI7i NHn499l/24h+IgKrDIAfYD4wxSzSZEH9jJZxLrk8bCinxWfAyvJuijsPcu2l+0jk MtWdbi+x1Yl0hCjfkCALiODCvfEjMSZU83tWWZooTrQ5LlNOnFL7TKvYS4Kw/PNw Ta8xogidczSJkgRwRzecLYAWmr8GAvH/iAZCF1Bl0FV8h1alyUQXYjxca97fOeQR 8pHPVJr7MN2BaJ4/SFPSrE97fYExhCQuyx1CrUbyXp0F/PAM2HaqYaun9Ky7xV2h gVymIGh8igsZXKf3GrFCIsITaI2fAPmzv4k+D8iAKNy2R3DwDffdVVazHEfzZEyO iTX3HADMBLeLZY7gU+QddqdtZOUI9hJziTOkNvICf1lXS/2eGLD5ua3lBwBjdItz T/TsuZenvT4M6QQBOeE8RdJEsIUgZvDvPXI6o0m3rhhNCSBp70waIq1HPs9tGzbb RwQhzsldur2uyzirCs0occ0VxrSrnC8bgrY6KdQNeWWDQxTJe1s= =4GNm -----END PGP SIGNATURE----- --z1xXoSzs7GU4qyqM-- --===============6754220400039358980== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6754220400039358980==--