From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8337740583 for ; Thu, 22 Dec 2022 19:27:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF38968BA6B; Thu, 22 Dec 2022 21:27:23 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F11B68B263 for ; Thu, 22 Dec 2022 21:27:17 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 2BMJRGR3027674 ; Thu, 22 Dec 2022 20:27:16 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 686B3EB5BC; Thu, 22 Dec 2022 20:27:16 +0100 (CET) Date: Thu, 22 Dec 2022 20:27:16 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <7407e74b181e4e00a7b7104fb63cf56a@huawei.com> <8870f5f386ee4042a8aa0303ace8c51f@huawei.com> MIME-Version: 1.0 In-Reply-To: <8870f5f386ee4042a8aa0303ace8c51f@huawei.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Thu, 22 Dec 2022 20:27:16 +0100 (CET) Subject: Re: [FFmpeg-devel] =?utf-8?b?562U5aSNOiAgW1BBVENIXSBmZnRvb2xzL2Zm?= =?utf-8?q?mpeg=5Fffplay=5Fffprobe=5Fcmdutils=3A_add_-mask=5Furl_to_replac?= =?utf-8?q?e_the_protocol_address_in_the_command_with_the_asterisk_=28*=29?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "wangqinghua \(I\)" Content-Type: multipart/mixed; boundary="===============2914278557202947123==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2914278557202947123== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3lvNZYqYRpA8x9P2" Content-Disposition: inline --3lvNZYqYRpA8x9P2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Wujian(Chin) (12022-12-20): > I think that it's more concise to use code this way. Concision is not the goal here, maintainability is. Please do not use gotos. > I think that it would be better to replace the entire url, so that the c= ode implementation is simple. Then replace the whole command line, it is even simpler. Also, this way you miss credentials passed through options. > >> + argv2 =3D av_mallocz(argc * sizeof(char *)); >=20 > >sizeof(*argv2) Youhoud? > This option needs to replace the URL. It is more appropriate to judge > mask_url and copy argv in this place. Otherwise, do you have any > other suggestions? Use the normal options parsing system. Regards, --=20 Nicolas George --3lvNZYqYRpA8x9P2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmOkr5IACgkQcZVLI8pN xgwlRBAAgMN5Mq3SP9CSnruRVuorShJsmYNF/pndx5d1bWPbWWyjH/RiL8n06gNx 0H1T5PzfniMrasfhwakXtDCPFmU3JTuCwXjPCoj12vQm9h+a57AVRGexLq5fLmuj lTso1ZvjGE9r80a8PF2PoiqTTJvSt77IKI3SGJntuz6fZaca6n6ByEUM/SQfyA2W QfQ1KQBBVQo3SBrF9caOUT1vB0jnNh490RjLKGDAHfw6vQd4+xZCWKw34D7vv95Q R9LrhAYwPGZumGbvOD8FVP4sPLpNeXH4RWH9na0R1hUoVSYIN9dMtnWczisaXb70 MZbt2gsH7MaoAEboLdzXYOGyqxwFoC8nLApltAKYswlc7utJ2TXB/7t0bxpjKpj6 Vjjx7vUW9sQV75B9sbuaJkD85c5WhzBXdKm7coI/JbzDixVJg2JgI9AGAvozQXOH Tp7NVHmen1Lu8O6+2swrSKNBYKnsSShFxS32mrcJRAK09SWTnZM4RpKqDSzuJ10X nDQZTOEIeBesgiQRxwkeZ/ZY2xOXZP8fhaks+A3VhOo1n6HhbutGuvCsCWwOhQ8N ohtJ/j80y9RqeQM9Fi3e6KgL8VaGwXHydp6UaBAGfUJ+tYOZZWT2YWYbjBZNu1tP HPRb9Y56QwLSxy2Fcup+F8kYBsTCcvpxUrPimnGwRn6n1Dd1MyU= =Dd7B -----END PGP SIGNATURE----- --3lvNZYqYRpA8x9P2-- --===============2914278557202947123== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2914278557202947123==--