Re: [FFmpeg-devel] [PATCH 2/3] avcodec/vqcdec: Check width & 15

From: Peter Ross <pross@xvid.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/vqcdec: Check width & 15
Date: Thu, 8 Dec 2022 18:32:40 +1100
Message-ID: <Y5GTGIqfvoa65Qo1@4eb231a0d1b36cedda43a2a005befe4d> (raw)
In-Reply-To: <20221127223435.8362-2-michael@niedermayer.cc>

[-- Attachment #1.1: Type: text/plain, Size: 1202 bytes --]

On Sun, Nov 27, 2022 at 11:34:34PM +0100, Michael Niedermayer wrote:
> Various parts of the code assume that width can be divided by various powers of 2
> without rounding
> 
> Fixes: out of array access
> Fixes: 53623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQC_fuzzer-6209269924233216
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/vqcdec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/vqcdec.c b/libavcodec/vqcdec.c
> index 18cd99462e..c3bce87974 100644
> --- a/libavcodec/vqcdec.c
> +++ b/libavcodec/vqcdec.c
> @@ -71,6 +71,9 @@ static av_cold int vqc_decode_init(AVCodecContext * avctx)
>      static AVOnce init_static_once = AV_ONCE_INIT;
>      VqcContext *s = avctx->priv_data;
>  
> +    if (avctx->width & 15)
> +        return AVERROR_PATCHWELCOME;
> +
>      s->vectors = av_malloc((avctx->width * avctx->height * 3) / 2);
>      if (!s->vectors)
>          return AVERROR(ENOMEM);
> -- 
> 2.17.1

ok. please apply.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".