From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7C02540861 for ; Tue, 29 Nov 2022 19:03:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C3A068B9E8; Tue, 29 Nov 2022 21:03:36 +0200 (EET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B74568B26F for ; Tue, 29 Nov 2022 21:03:29 +0200 (EET) Received: by mail-pl1-f175.google.com with SMTP id y17so6466793plp.3 for ; Tue, 29 Nov 2022 11:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u7PP9JxXWfB05zq+PLfaU0rfysQyVezxU0ruWPTpYkU=; b=I52o8B23+qgO5lZxz1rmglDPxWqGlqaZ/n0695Rx4MWnp6fJHVgM18K6IxsqY5rveL pL2o2KWjclc3S3VmDNfcYpjYkfqLgiVHiBIKiXNrH5aH4BiPK6xmZFOxEfdCX3wp5Wq0 AWFV8z8VxuVhEwmx7JqCOMgzMycSjE3aIJjdI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u7PP9JxXWfB05zq+PLfaU0rfysQyVezxU0ruWPTpYkU=; b=OH/tmjIk5/6TqtKofaT+NBVCnSuUaOduFh4r+EnEbqwBVvErOhwTQec7el1dgyXO8Y srsjdfxGpOh1Zb3l+kUI7osQeed10xxFAlK5h4Z+SqOlE58nJONztRl6Koq79zw4pFA+ QiO1pMiy6i7QZkMpWnc0xdsf9BLYdB0DI5JEfZIUxkvtg28x2Xmdhi59JSE+8t/Rk5aI dq38uF+zUVJA9GXAOc2FBduzg/Gu4G+PHqctSO/RvK1T801//qILWe2mLgKD7CQS2XDg pMFUFbMWNkhZIiB6Muwko/KTNPzoI0RhGhBWoDIv6Jg634423ZAdcgLByLJMrHHOLH9g qwJA== X-Gm-Message-State: ANoB5pmDa6gz3qLSVsKVWDe77Ee/jeEYZwvgCVOBF6opAsnG+hKe1b4T 2gLI0eJpATUKuUuPHnA25MYhBQrls2kLYg== X-Google-Smtp-Source: AA0mqf7c39BtC8YNKPvAZ7uYtQDlPZOWBrJD89LT7E8aCQN2O99F9bEoAjy+FvO7aOPmrB0qxpYEsg== X-Received: by 2002:a17:90b:3802:b0:213:48b2:123d with SMTP id mq2-20020a17090b380200b0021348b2123dmr65737611pjb.200.1669748607001; Tue, 29 Nov 2022 11:03:27 -0800 (PST) Received: from google.com ([2620:15c:9d:2:bdc2:b377:8fc0:83ef]) by smtp.gmail.com with ESMTPSA id o191-20020a62cdc8000000b005756a67e227sm2103091pfg.90.2022.11.29.11.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 11:03:26 -0800 (PST) Date: Tue, 29 Nov 2022 11:03:24 -0800 From: Brian Norris To: FFmpeg development discussions and patches , anton@khirnov.net Message-ID: References: <20221123215444.1754721-1-briannorris@chromium.org> <166972111144.4503.13564943385890113995@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <166972111144.4503.13564943385890113995@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Skip 'vgem' driver X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Anton, On Tue, Nov 29, 2022 at 12:25:11PM +0100, Anton Khirnov wrote: > I'm not the maintainer for this, but I wonder if it wouldn't be cleaner > to instead add something like a 'kernel_driver_blacklist' option that > would contain a comma-separated list of ignored drivers, and default to > 'vgem' (with maybe more added later). I could go for a list of some kind to make this more extensible, if it's worthwhile. But is it important to make it an "option" (as in, CLI option presumably)? Comma-separated is especially tricky, as I believe the existing dict/arg parsing uses commas to delimit separate key/value pairs. I suppose I could use "+", as there's precedent in vulkan (instance_extensions, etc.). It also feels like "user-configurable" and "default list" are somewhat at odds, because the default list has good reason to be there, and yet might change underneath the user across versions (if there are new vgem-like drivers, etc.). So any CLI user would have to keep up to date with the defaults. I suppose maybe that's not a horrible problem; I'm just trying to think it through, as I wouldn't personally have any need for it if the default list is good. Thanks for your thoughts. Brian _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".