From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id EEE7A44E32
	for <ffmpegdev@gitmailbox.com>; Fri, 25 Nov 2022 23:43:54 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C511968B7E9;
	Sat, 26 Nov 2022 01:43:52 +0200 (EET)
Received: from mx.sdf.org (mx.sdf.org [205.166.94.24])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9FFF468B125
 for <ffmpeg-devel@ffmpeg.org>; Sat, 26 Nov 2022 01:43:45 +0200 (EET)
Received: from 4eb231a0d1b36cedda43a2a005befe4d ([1.136.212.215])
 (authenticated (0 bits))
 by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 2APNhcLQ008542
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO)
 for <ffmpeg-devel@ffmpeg.org>; Fri, 25 Nov 2022 23:43:43 GMT
Date: Sat, 26 Nov 2022 10:43:34 +1100
From: Peter Ross <pross@xvid.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <Y4FTJqx8o0K8cDmc@4eb231a0d1b36cedda43a2a005befe4d>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
References: <20221125201833.20355-1-michael@niedermayer.cc>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20221125201833.20355-1-michael@niedermayer.cc>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pictordec: Remove mid exit branch
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/Y4FTJqx8o0K8cDmc@4eb231a0d1b36cedda43a2a005befe4d/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Fri, Nov 25, 2022 at 09:18:33PM +0100, Michael Niedermayer wrote:
> This causes the RLE decoder to exit before applying the last RLE run
> All images i tested with are unchanged, this makes the special case
> for handling the last run unused for non truncated images.
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/pictordec.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/libavcodec/pictordec.c b/libavcodec/pictordec.c
> index 09229b94fd..27f5b96571 100644
> --- a/libavcodec/pictordec.c
> +++ b/libavcodec/pictordec.c
> @@ -246,8 +246,6 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *frame,
>                          run = bytestream2_get_le16(&s->g);
>                      val = bytestream2_get_byte(&s->g);
>                  }
> -                if (!bytestream2_get_bytes_left(&s->g))
> -                    break;
>  
>                  if (bits_per_plane == 8) {
>                      picmemset_8bpp(s, frame, val, run, &x, &y);
> -- 
> 2.17.1

ok

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".