Re: [FFmpeg-devel] [PATCH 2/3] avformat/electronicarts: set packet_read in one place

From: Peter Ross <pross@xvid.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marton Balint <cus@passwd.hu>
Subject: Re: [FFmpeg-devel] [PATCH 2/3] avformat/electronicarts: set packet_read in one place
Date: Thu, 17 Nov 2022 18:30:26 +1100
Message-ID: <Y3XjEsMX3xURzDjP@4eb231a0d1b36cedda43a2a005befe4d> (raw)
In-Reply-To: <20221113184441.1741-2-cus@passwd.hu>

[-- Attachment #1.1: Type: text/plain, Size: 1118 bytes --]

On Sun, Nov 13, 2022 at 07:44:40PM +0100, Marton Balint wrote:
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  libavformat/electronicarts.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c
> index 0a0d6249e8..0532264f38 100644
> --- a/libavformat/electronicarts.c
> +++ b/libavformat/electronicarts.c
> @@ -726,8 +726,9 @@ get_video_packet:
>                  ret = av_append_packet(pb, pkt, chunk_size);
>              } else
>                  ret = av_get_packet(pb, pkt, chunk_size);
> +            packet_read = 1;
> +
>              if (ret < 0) {
> -                packet_read = 1;
>                  partial_packet = 0;
>                  break;
>              }
> @@ -737,7 +738,6 @@ get_video_packet:
>              else
>                  pkt->stream_index = ea->video.stream_index;
>              pkt->flags       |= key;
> -            packet_read       = 1;
>              break;
>  
>          default:

lgtm

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".