Re: [FFmpeg-devel] [PATCH v2 0/3] Some small ASS conversion fixes

[Oneric <oneric@oneric.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1503 bytes --]

On Sun, Nov 13, 2022 at 20:15:23 +0000, Soft Works wrote:
> 
> [...] it's not a Patchwork bug and it cannot be "fixed"
> at all in any other way than using binary diffs. The problem lies in 
> the fact that it's being sent by e-mail where the different line
> endings get lost (as the spec mandates CRLF and doesn't allow LF only).

As last time: No, emails are perfectly capable of preserving CRLF line
endings via e.g. "quoted-printable" or "base64" transfer-encoding and
that’s what git send-email automatically uses.

As a case in point of it not being "just" patchwork, there’s the
troubles with patch 3 of this series already as sent out by the list.
This is most likely to blame on the list itself and its message-editing to
add a footer though, and not on git send-email or email in general.

> Caveats when testing: Your local generated .patch files still work
> and depending on your e-mail client, even the patch in your sent items
> folder might not work. But as soon as it's been sent via SMTP the
> different line ending get lost.

And again like last, time I do ofc check the sent&received emails and not
local patch files. You can easily verify emails are capable of it by
applying patch 2 yourself or using patchwork’s mbox file.

Please actually focus on the patch this time. I have no need for repeating
the same long tangent about email and transfer encodings as last time, so
I’ll ignore all further messages from you not about the code changes.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".