From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 004B34407E for ; Thu, 24 Nov 2022 18:12:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1348968B418; Thu, 24 Nov 2022 20:12:54 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D6F1768A119 for ; Thu, 24 Nov 2022 20:12:47 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 2AOICk3g028541 for ; Thu, 24 Nov 2022 19:12:46 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 7963EEB5C3; Thu, 24 Nov 2022 19:12:46 +0100 (CET) Date: Thu, 24 Nov 2022 19:12:46 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Thu, 24 Nov 2022 19:12:46 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] avformat/file: Fix handing of file URIs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4913703481423706802==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4913703481423706802== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qhb7U895XAKLcwZS" Content-Disposition: inline --qhb7U895XAKLcwZS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Nick Sarnie (12022-11-24): > The current URI handling only removes the file: prefix, but we also need = to > consider the case of percent encoding. > Percent encoding can happen with non-ASCII characters in the path. NAK, this is a huge compatibility break. But this fix is necessary, you are right. What needs to happen to handle this correctly: - Introduce a =E2=80=9Cfs:=E2=80=9D protocol as a synonym to file:. - Change =E2=80=9Cfile:=E2=80=9D (but not =E2=80=9Cfs:=E2=80=9D!) to detect= if the rest of the path looks like a real file URL or a raw file path. - If it looks like a real file URL, de-percent-escape it. - If it looks like a raw file path, treat it the legacy way after printing a warning. - In a few years, remove the heuristics and always handle =E2=80=9Cfile:=E2= =80=9D in the standards-compliant way. I believe we can ignore incomplete / relative file:// URLs in the transition period. The triple / would be a very reliable way of identification. Regards, --=20 Nicolas George --qhb7U895XAKLcwZS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmN/tBwACgkQcZVLI8pN xgz5PRAAo98ubcO2LHpdP7UNqvs4WhO/tCv3psXCUGcHIGDFFUJvy+ePazeHcJxf l2h1ZkGMcpLfG4jiOkCcyQcWg1gD9Jar4CU0qWHpFg3XHhau1WRiWd86x7AWM3zH P2bxKUT/FwcqvXcOxKqsJ7bUwxFQXAEvHBaG2BIfw2+5il+0OuZxL5D1cjlH/gsl QgyBd8p7HfdNzi0NHYTk6Hche96NrFiXYLey2C339ki1Mz+YiSruFBZcEKgro7Oe jSy7kLTLhRvlP5ytafUX91i0rRcwGH+OEI1JgyvJ2H8RHVgLmBlG3yM7O3RIuEvy DM60CgeWzMjjCsoC99IMSCZ6L2cd07Ax2hLZijvEmbUu/B0mqP2nxDl0pac/qBx6 az3ToZdW/PI+xcp1pTCvv1Hmdh5MccF9vbnE4pszgekVgUK/86sFXz3CVrzMD1qG x5XzSO/MKd956FpaIRIDiCkZUuuGvKTkwM8mMIvG9AONcGy26cAHhDmqNNlfnhIc nReuLbrntDmPXqFBIZQsshmDUmm1qFk8ivO22a5ZygwD899vK4GrSdaoQd5XP6ft K/eX4bkq9hGwCGqiEPlSMpXicmYurt5tE+MKrdAfPI4KlmmqWEsaR6zZrieOkTU0 ztXAu4fofXh8ot90fDJU9h1ge3Ok1ZpinYX99azRlRZ6MLvu0E8= =ZIFB -----END PGP SIGNATURE----- --qhb7U895XAKLcwZS-- --===============4913703481423706802== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4913703481423706802==--